angularjs skip over object if its missing attributes

Question

I have a filter that looks over objects in an array to see if the distance of the latitude and longitude of the object are within the user's selected range. However, the problem is that some of the objects do not have latitude and longitude attributes at all, and this breaks the filter. Is there a way to "skip" over the object if it does not have lat and long? or if its lat and long are 0?

Code:

    function distanceFromFunc(distanceFrom) {

      var m;
      var n;
      var positionContainer = [];
      var docLat;
      var docLon;
      var rowIdFromObj;
      var rowObj;
      var rowsArray;

      if (distanceFrom === "1") {
        vm.selectedRadius = 1609.344 //1 mile
      } else if (distanceFrom === "2") {
        vm.selectedRadius = 3218.688 //2 miles
      } else if (distanceFrom === "5") {
        vm.selectedRadius = 8046.720 //5 miles
      } else if (distanceFrom === "10") {
        vm.selectedRadius = 16093.440 //10 miles
      } else if (distanceFrom === "20") {
        vm.selectedRadius = 32186.880 //20 miles
      } else if (distanceFrom === "50") {
        vm.selectedRadius = 80467.200 //50 miles 
      } else if (distanceFrom === "999999") {
        vm.selectedRadius = 0
      };

      //THE PROBLEM HERE IS THAT WHEN IT HITS A RECORD WITHOUT LAT AND LONG
      //THE FUNCTION BREAKS
      function filterByDist(value) {
        console.log("VALUE IS ------>" + JSON.stringify(value));
        var dist = distance(myLat, myLon, value.locations[0].Lat, value.locations[0].Long);
        if (dist <= distanceFrom) {
          console.log("the dist is: " + dist);
          return value
        };
      };

      var digestedArray = originalData2.filter(filterByDist)
      $scope.locatorGridData = digestedArray;

   }; //end func

I beleive it breaks on this line: var dist = distance(myLat, myLon, value.locations[0].Lat, value.locations[0].Long);

Teddy Sterne · Accepted Answer · 2017-01-18 15:30:58Z

1

Should be able to just modify the offending line to be:

var dist;
if (value.locations && value.locations.length &&
    value.locations[0].Lat && value.locations[0].Long){
    dist = distance(myLat, myLon, value.locations[0].Lat, value.locations[0].Long);
}

answered Jan 18, 2017 at 15:30

Teddy Sterne

14.3k2 gold badges49 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

rrd · Accepted Answer · 2017-01-18 15:29:32Z

1

Just a little bit of checking before you make the distance method call:

function filterByDist(value) {
  if (value.locations[0].Lat && value.locations[0].Long) {
    var dist = distance(myLat, myLon, value.locations[0].Lat, value.locations[0].Long);
    if (dist <= distanceFrom) {
      return value
    }
  }
}

That assumes that the error does occur where you think, ofc! But it does appear plausible that it would error there.

answered Jan 18, 2017 at 15:29

rrd

5,9873 gold badges32 silver badges37 bronze badges

Comments

Mistalis · Accepted Answer · 2017-01-18 15:31:03Z

1

The following code checks if:

value and value.locations are defined
Lat and Long exists

The distance is only calculated if these conditions are satisfied.

if(value && value.locations.length && value.locations[0].Lat && value.locations[0].Long) {
     // Calculate distance
}

answered Jan 18, 2017 at 15:31

Mistalis

18.3k14 gold badges78 silver badges97 bronze badges

Collectives™ on Stack Overflow

angularjs skip over object if its missing attributes

3 Answers 3

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Related