Iteratively adding up first and last numbers in an array

Question

I'm trying to write a function that continually adds together the first and last elements of an array using forEach with array.shift() + array.pop().

The problem is that the for-loop doesn't complete the innermost numbers, and so the array is always left with 2 values inside of it.

Code:

function choreAssignment(chores) {
  chores.sort(function(a, b) {return a - b});
  var assignment = [];
  chores.forEach(function() {
  assignment.push((chores.pop() + chores.shift()));
});
  return assignment.sort(function(a, b) {return a - b});
}

The above code works as expected, but it leaves the innermost two values inside the chores array.

For example if I run:

Code:

var arr = [1, 4, 7, 2, 5, 9, 4, 3];
choreAssignment(arr);

I get:

[8, 9, 10]

Ie, it adds 9 & 1, 7 & 2, 5 & 3, but it leaves [4, 4] inside the array.

I'm not sure why this is. Thank you.

Answer 1

Try changing the forEach to:

while (chores.length) {
    assignment.push((chores.pop() + chores.shift()));
}

Note this assumes there are always an even number of elements in array