Reset array keys in multidimensional array, recursive, by reference

Question

I want to reset keys in a big, multidimensional array. I already found a solution which is actually work:

$fix_keys = function(array $array) use (&$fix_keys)
{
    foreach($array as $k => $val)
    {
        if (is_array($val))
        {
            $array[$k] = $fix_keys($val);
        }
    }
    return array_values($array);
};

and the problem is, if I pass big arrays to it, it becomes slow and memory consuming. What about refactoring with working references:

$fix_keys = function(array &$array) use (&$fix_keys)
{
    foreach($array as $k => &$val)
    {
        if (is_array($val))
        {
            $array[$k] = $fix_keys($val);
        }
    }
    unset($val);
    $array = array_values($array);
};

but it messed up the array, all I get is [0] => null. What is wrong?

Edit: so input data:

$a = [
    'a' => 1,
    'b' => 2,
    'c' => [
        'aa' => 11,
        'bb' => [
            'ccc' => 1
        ],
        'cc' => 33
    ]
];

and I want to have:

array(3) {
  [0]=>
  int(1)
  [1]=>
  int(2)
  [2]=>
  array(3) {
    [0]=>
    int(11)
    [1]=>
    array(1) {
      [0]=>
      int(1)
    }
    [2]=>
    int(33)
  }
}

Can you post some input along with expected output

Narendrasingh Sisodia
– Narendrasingh Sisodia

2016-11-14 10:13:40 +00:00
Commented Nov 14, 2016 at 10:13 — Narendrasingh Sisodia
– Narendrasingh Sisodia, Commented Nov 14, 2016 at 10:13

Andrei · Accepted Answer · 2016-11-14 10:22:18Z

2

If memory is an issue you can try using yield. I'm not sure if this fits your needs, but here it is:

function reduce($array){
  foreach($array as $key => $value){
    if(is_array($value)){
      reduce($value);
    }
  }

  yield array_values($array);
}

You can also use send if you need to apply some logic to the generator.

answered Nov 14, 2016 at 10:22

Andrei

3,6385 gold badges23 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

John Smith · Accepted Answer · 2016-11-14 10:57:18Z

0

I found the solution:

$fix_keys = function(array &$array) use (&$fix_keys)
{
    foreach(array_keys($array) as $k)
    {
        if (is_array($array[$k]))
        {
            $fix_keys($array[$k]);
        }
    }
    $array = array_values($array);
};

answered Nov 14, 2016 at 10:57

John Smith

6,26517 gold badges79 silver badges131 bronze badges

Collectives™ on Stack Overflow

Reset array keys in multidimensional array, recursive, by reference

2 Answers 2

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Related