How to create folders dynamically using PowerShell?

Question

Requirement: I am trying to create the BKP folder in 10 server using the below code but some how it is not creating the new folder in servers.

foreach ($instance in Get-Content "C:\servers\List.txt")
{
    $local = Get-Location;
    $final_local = "C:\BKP";

    if (!$local.Equals("C:\"))
    {
        cd "C:\";
        if ((Test-Path $final_local) -eq 0)
        {
            mkdir $final_local;
            cd $final_local;
        }

        ## if path already exists
        ## DB Connect
    }
}

Hi Arashzag , thanks for reply, Already I used mkdir in my code.can you try to share the code which can help me. — Franklin
– Franklin, Commented Oct 19, 2016 at 5:57

Lieven Keersmaekers · Accepted Answer · 2016-10-19 06:32:51Z

2

First : you are using the wrong test, you should use :

if($local.Path -eq "C:\")

The equal method is there to compare objects have a look to :

$local | get-member
$local | fl *

Be careful PowerShell CmdLet return objects.

Second : if $local.Path is equal to "C:\", you create nothing.

Your code would look like :

ForEach ($instance in $(Get-Content "C:\servers\List.txt")) 
{ 
  $local = Get-Location;
  $final_local = "C:\BKP";

  if($local.Path -ne "C:\")
  {
    cd "C:\";
    if((Test-Path $final_local) -eq 0)
    {
      mkdir $final_local;
      cd $final_local;
    }

    ## if path already exists
    ## DB Connect
}

edited Oct 19, 2016 at 6:32

Lieven Keersmaekers

58.9k15 gold badges117 silver badges151 bronze badges

answered Oct 19, 2016 at 5:58

JPBlanc

73k17 gold badges137 silver badges180 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Franklin Over a year ago

Its creating folder in Local instead of remote servers specified in the c:\server\list.txt

JPBlanc Over a year ago

Your test is not the good one .Equals do not do what you expect.

Franklin Over a year ago

Thanks JPBlanc for your reply. I didn't understand. Please change my code .

JPBlanc Over a year ago

I do not try to understand the context, i just change your test (the if clause).

Lieven Keersmaekers Over a year ago

@Franklin - you are looping over the contents of a serverlist but you are nowhere connecting to that server *(by share or remoting) to create the folder.

|

saftargholi · Accepted Answer · 2016-10-19 07:20:40Z

0

use this command to create directory :

ForEach ($instance in Get-Content "C:\servers\List.txt") 

{ 
$local = Get-Location;
$final_local = "C:\BKP";

if(!$local.Equals("C:\"))
{
    cd "C:\";
    if((Test-Path $final_local) -eq 0)
    {
        New-Item -ItemType Directory -Force -Path "$final_local";
        cd $final_local;

    }

    ## if path already exists
    ## DB Connect

}

}

answered Oct 19, 2016 at 7:20

saftargholi

1,0101 gold badge13 silver badges25 bronze badges

3 Comments

Franklin Over a year ago

I didn't find any difference for the script I posted and the above code.

Franklin Over a year ago

still I can see the folder is created in local only

Franklin Over a year ago

Can some one help me on this Topic

Ashu · Accepted Answer · 2016-10-19 08:33:04Z

Try using the invoke-command i am assuming credentials are needed for the servers you can skip it if it works for you.

$credentials = Get-Credential

$create = { $local = Get-Location;
            $final_local = "C:\BKP"

             if(!$local.Equals("C:\")){
                cd "C:\";
                 if((Test-Path $final_local) -eq 0){
                      New-Item -ItemType Directory -Force -Path "$final_local";
                      cd $final_local;
               }
         ## if path already exists
           ## DB Connect
     }
 }
ForEach ($instance in Get-Content "C:\servers\List.txt")  {
Invoke-Command -ScriptBlock $create -ComputerName $instance -Credential $credentials
}

Thansk Ashu for your help but unfortunately it is not working.I mean its creating on local drive only.

Collectives™ on Stack Overflow

How to create folders dynamically using PowerShell?

3 Answers 3

6 Comments

3 Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

3 Comments

1 Comment

Related