Issue with outputting multiple values

Question

I am writing a script to gather data about domain computers and I ma trying to output this to a csv file. However its not coming out the way I want it to.

Here is my code:

Set-ExecutionPolicy Unrestricted -force
Import-Module ActiveDirectory

$CSVPath = $ScriptFolderPath + "\" + $ScriptName + ".csv" 
$Import = Get-Content "c:\T2\AD Computers Scripts\ComputersTest.csv"

foreach ($Member in $Import)
{
    $ComputerName = Get-ADComputer $Member -Properties Name, CanonicalName | Select Name, CanonicalName

    $ConnectionStatus = Test-Connection $Member -Quiet
    IF ($ConnectionStatus -eq $TRUE)
    {
      $IPAddress = Test-Connection $Member -Count 1  | Select -ExpandProperty IPV4Address
    }
    ELSE
    {
      $IPAddress = "Not able to contact server"
    }

    $CSVPath

    $Report1 = $ComputerName | ForEach -Process {$_ | Add-Member -Name IPAddress -Value $IPAddress -MemberType NoteProperty -PassThru}
    $Report1 | Add-Member -Name Subnet -Value $CSVPath -MemberType NoteProperty -PassThru
    $Report1
    "`n`n`n"

The out put looks like this:

Name                          CanonicalName                 IPAddress                     Subnet
----                          -------------                 ---------                     ------
CEN-RVS                       abc.local/Servers/Corpora... 10.19.95.2                    C:\t2\AD Computers Scripts
CEN-RVS                       abc.local/Servers/Corpora... 10.19.95.2                    C:\t2\AD Computers Scripts

All I need is a single line. It should look like this:

Name                          CanonicalName                 IPAddress                     Subnet
----                          -------------                 ---------                     ------
CEN-RVS                       abc.local/Servers/Corpora... 10.19.95.2                    C:\t2\AD Computers Scripts

Where's the rest of your script? You want it to say "Subnet: c:\t2\AD Computer Scripts" ? — TessellatingHeckler
– TessellatingHeckler, Commented Aug 16, 2016 at 19:02

Mathias R. Jessen · Accepted Answer · 2016-08-16 19:20:03Z

2

The -PassThru parameter to Add-Member means "output the modified object".

Thus, these two statements are (apart from the side-effect of adding a NoteProperty to $Report1) redundant:

$Report1 | Add-Member -Name Subnet -Value $CSVPath -MemberType NoteProperty -PassThru
$Report1

Either remove the $Report1 statement at the end or remove -PassThru switch from the Add-Member statement

answered Aug 16, 2016 at 19:20

Mathias R. Jessen

178k13 gold badges175 silver badges234 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Issue with outputting multiple values

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related