SqlCommand INSERT query does not insert data into the database

Question

I am working on Visual Studio 2013.

In the below code the MessageBox.Show("Connected to database") is shown correctly, but the SQL query is not inserting data into the database table.

When I insert data manually then it inserts without any problems. But unfortunately the data fails to insert on the button_click command.

private void DataAdd_Load(object sender, EventArgs e)
{
    try
    {
        conn = new SqlConnection("Data Source=(LocalDB)\\MSSQLLocalDB;AttachDbFilename=Pathname;Integrated Security=True;Connect Timeout=30");
        conn.Open();
        MessageBox.Show("Connected to database");
        cmd = new SqlCommand("INSERT INTO datains (name, dob, gender, occupation, height, weight, relation, polexpo) values('abc', '22-Aug-2001', 'Male', 'qwe2', '23', '431', 'qw23e', 'asqwed');", conn);
    }
    catch (Exception e1)
    {
        MessageBox.Show("Connection failed");
    }
}

What have I done wrong here or anything I have missed?

Is DataAdd_Load called? Do you get any exception?, you did not close the connection which you must. — Adil
– Adil, Commented Aug 9, 2016 at 9:30
Possible duplicate of SqlCommand INSERT INTO query does not execute — Mong Zhu
– Mong Zhu, Commented Aug 9, 2016 at 9:32
@Adil it was my silly mistake of not writing the cmd.ExecuteNonquery , wondering for hours and finally stack overflow helped!. Thanks for helping! — amish
– amish, Commented Aug 9, 2016 at 9:42

Peter Mortensen · Accepted Answer · 2017-09-14 21:45:56Z

5

You have forgotten to execute the query:

cmd.ExecuteNonQuery();

It is also better to close the connection after the work is done:

conn.Close();

edited Sep 14, 2017 at 21:45

Peter Mortensen

31.4k22 gold badges110 silver badges134 bronze badges

answered Aug 9, 2016 at 9:31

Mostafiz

7,3523 gold badges30 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user6996876 · Accepted Answer · 2016-08-09 09:40:03Z

1

You have to run the ExecuteNonQuery() method of your cmd to make it work, but it's also advisable to wrap both connection and command into a using statement so that they will be disposed (the connection should be also explicitly closed)

answered Aug 9, 2016 at 9:40

user6996876

Collectives™ on Stack Overflow

SqlCommand INSERT query does not insert data into the database

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related