PHP template system with while loop

Question

I'm trying to make a simple template system because I don't want to use Smarty or anything like that.

My current problem is that I can't make 1 tag print every result from a while loop. It only prints the first result.

public $TplKey = array();

public function GetContent($file, $data) {
    $template = file_get_contents($file);

    foreach($data as $key => $value) {
        $template = str_replace('{'.$key.'}', $value, $template);
    }

    return $template;
}

public function View($file) {
    return $this->GetContent($file, $this->TplKey);
}

public function TplKeyAdd($key, $value) {
    return $this->TplKey += array($key => $value);
}

public function testing() {
    global $DBHandle;

    $q = $DBHandle->mysqli->query("SELECT * FROM site_users");
    while($qf = $q->fetch_array()) {
        $r = $this->TplKeyAdd("var", $qf["user_name"]);
    }

    return $r;
}

Then, later on in my .TPL file I call {var}. But it only shows the first database row (as stated). I want it to show every row it can find. How can I solve this?

If you return in a while loop, you'll only ever get one iteration of it — iainn
– iainn, Commented Jul 7, 2016 at 11:41
I know you said you don't want to use an existing template system, but I'm curious why not. Aren't you just re-inventing the wheel now? You could have long since installed Smarty or Twig, learned the syntax, and then moved onto your next task by now. — Ben Hillier
– Ben Hillier, Commented Jul 7, 2016 at 11:52
@BenHillier I just want to get some experience with it. I know it's like re-inventing the weel, but I don't mind. — P. Nick
– P. Nick, Commented Jul 7, 2016 at 11:54

Community · Accepted Answer · 2017-05-23 12:16:18Z

0

Your issue lies with how you're storing the key => value pairs in the TplKeyAdd method.

I believe you're after:

public function TplKeyAdd($key, $value) {
    return $this->TplKey[] = array($key => $value);
}

Also with this:

$this->TplKeyAdd("var", $qf["user_name"]);

The key you're adding every time is called "var" so each value from the database doesn't have it's own key.

Edit: Also as ianinn pointed out, you shouldn't be returning within your while look as it'll only get the first iteration.

edited May 23, 2017 at 12:16

CommunityBot

11 silver badge

answered Jul 7, 2016 at 11:41

user128161

Sign up to request clarification or add additional context in comments.

6 Comments

P. Nick Over a year ago

I get "Array to string conversion" with that method. Also, since the array is already made before that function, I have to use "+=" and not "=", but that gives me "Unsupported operand types"...

P. Nick Over a year ago

I don't wish to use multiple "var" keys for every result. I wish to have one "var" key and make it print out every result if it's from a loop.

user128161 Over a year ago

So why are you using a while loop when you only want one result?

P. Nick Over a year ago

You got me wrong there. I want all rows from the database table, but I want to show them all only with one "var" tag.

user128161 Over a year ago

Sorry, I don't understand. You want all your database rows to populate a single {var} tag?

|

Collectives™ on Stack Overflow

PHP template system with while loop

1 Answer 1

6 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Related