select query BETWEEN two dates in WindowsForms Application c#

Question

I have a problem with the query BETWEEN .I'm trying to select records from a table between two dates, SO, I used the following query :

SqlDataAdapter sda1 = new SqlDataAdapter(
  "select distinct * from BLC where DATE_BLC between '" + 
   dateTimePicker1.Value.ToString() + "' and'" + 
   dateTimePicker2.Value.ToString() + "'", conx);

When I enter the following dates :

From date 05/02/2016 To date 15/03/2016

It returns the records between (06/02/2016 to 15/03/2016) date but the records that begin with date 05/02/2016 , they are not returned. and when I choose the date (From 05/02/2016 to 05/02/2016 ) there is no records here. Can someone tell me what I'm doing wrong here?

your dateTimePicker1 is sending time stamp also to SQL, try to pass only Date — techspider
– techspider, Commented Apr 27, 2016 at 13:58
parameterized queries. Query parameters also have the nice features of being faster and avoiding issues with single quotes in fields or formatting issues with dates. — Joel Coehoorn
– Joel Coehoorn, Commented Apr 27, 2016 at 16:24

LarsTech · Accepted Answer · 2016-04-27 14:54:41Z

8

It is a better codding practice to use parameters as they will sterilize any inputs for any queries and are generally safer to user. Thus the code would become

SqlDataAdapter sda1 = new SqlDataAdapter("select distinct * from BLC where DATE_BLC between @Date1 and @Date2", conx);
sda1.SelectCommand.Parameters.Add(new SqlParameter("@Date1", dateTimePicker1.Value));
sda1.SelectCommand.Parameters.Add(new SqlParameter("@Date2", dateTimePicker2.Value));

edited Apr 27, 2016 at 14:54

LarsTech

81.8k14 gold badges161 silver badges237 bronze badges

answered Apr 27, 2016 at 14:19

Shon

4864 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

techspider · Accepted Answer · 2016-04-27 13:59:25Z

1

Try to pass only Date value instead of DateTime value

SqlDataAdapter sda1 = new SqlDataAdapter("select distinct * from BLC where DATE_BLC between '" + dateTimePicker1.Value.Date.ToShortDateString() + "' and'" + dateTimePicker2.Value.Date.ToShortDateString() + "'", conx);

answered Apr 27, 2016 at 13:59

techspider

3,40814 gold badges39 silver badges65 bronze badges

4 Comments

tobypls Over a year ago

@Y.Arsoy you should mark the answer as the correct solution if it solved your problem.

Y.Arsoy Over a year ago

@tobypls I am new here , I didn't find where should i mark it solved ?

techspider Over a year ago

@Y.Arsoy - there should be a tick mark right below down arrow left to this answer

tobypls Over a year ago

@Y.Arsoy meta.stackexchange.com/questions/147531/…

Collectives™ on Stack Overflow

select query BETWEEN two dates in WindowsForms Application c#

2 Answers 2

Comments

4 Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Related