Why show Undefined variable error in Laravel 5.2?

Question

First take a look my working file.

ActionController.php:

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Action;
use App\Role;
use App\Http\Requests;

class ActionController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        //

        $actions = Action::where('id','>=',1)->paginate(10);

        $roles = Role::all();
        $data = ['roles' => $roles];
        return view('actions.index',['actions'=>$actions]);
    }

index.blade.php:

<table id="example2" class="table table-bordered table-hover" width="100%">

    <thead>
        <tr>
            <th>URI</th>
            <th>Action</th>
            @foreach($roles as $role)
               <th>{{$role->role}}</th>
            @endforeach
        </tr>
    </thead>
        <tbody>
    @foreach($actions as $action)

        <tr>
            <td>{{$action->uri}}</td>
            <td>{{$action->action}}</td>
            <td>{{$action->role}}</td>
        </tr>

    @endforeach
    </tbody>
</table>

When i trying to show actions in foreach its working fine but when i want to show roles in foreach loop then its showing Undefined variable: roles error. How can i show the roles in actions index?

Pankaj Makwana · Accepted Answer · 2017-10-24 08:03:28Z

2

Change in your ActionController.php. You need to create an array you want access in the view, so create an array called $data and pass it to the view. After passing array in the view you will be able to access variable you have passed in the controller like you have passed roles and actions so you can access it by it's name $roles and $actions from the view.

public function index(){
    $actions = Action::where('id','>=',1)->paginate(10);

    $roles = Role::all();
    $data = ['roles' => $roles, 'actions'=>$actions];
    return view('actions.index',$data); // 
}

edited Oct 24, 2017 at 8:03

Pankaj Makwana

3,0486 gold badges33 silver badges49 bronze badges

answered Apr 19, 2016 at 6:53

Amit Visodiya

8136 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Narendrasingh Sisodia · Accepted Answer · 2016-04-19 06:53:24Z

1

Because you were not passing $roles variable within your view it should be passed it like as

return view('actions.index',['actions'=>$actions])->withRoles($roles);

or you can simply pass it like as of actions

return view('actions.index',['actions'=>$actions,'roles' => $roles]);

or

$data = ['actions'=>$actions,'roles' => $roles];
return view('actions.index',$data);

answered Apr 19, 2016 at 6:53

Narendrasingh Sisodia

21.4k6 gold badges51 silver badges54 bronze badges

Comments

Nelson Melecio · Accepted Answer · 2016-04-19 06:54:17Z

1

try this:

public function index()
{
    //

    $actions = Action::where('id','>=',1)->paginate(10);

    $roles = Role::all();
    return view('actions.index',array('actions'=> $actions, 'roles' => $roles));
}

answered Apr 19, 2016 at 6:54

Nelson Melecio

1,5143 gold badges14 silver badges21 bronze badges

Comments

Jerodev · Accepted Answer · 2016-04-19 06:54:43Z

1

You are not passing the data variable to your view, it should be added to the array you are passing.

return view(
    'actions.index',
    [
        'actions' => $actions,
        'roles' => $roles
    ]
);

answered Apr 19, 2016 at 6:54

Jerodev

33.3k11 gold badges96 silver badges113 bronze badges

Comments

Alexey Mezenin · Accepted Answer · 2016-04-19 07:00:31Z

1

Since you have same names both for variables and collections, it's better to use compact():

return view('actions.index', compact('roles', 'actions'));

This will automatically convert names to an array and will pass all the data into the view.

answered Apr 19, 2016 at 7:00

Alexey Mezenin

164k27 gold badges308 silver badges287 bronze badges

Comments

Mushangi Derrick · Accepted Answer · 2016-04-19 07:00:44Z

1

This looks more cleaner. php compact

return view('actions.index', compact('roles', 'actions'));

answered Apr 19, 2016 at 7:00

Mushangi Derrick

1349 bronze badges

1 Comment

Chonchol Mahmud Over a year ago

Thanks.Its helped.

Collectives™ on Stack Overflow

Why show Undefined variable error in Laravel 5.2?

6 Answers 6

Comments

Comments

Comments

Comments

Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

1 Comment

Related