Batch for loop w/ multiple commands

Question

Any idea why this wouldn't work? I'm trying to create a file scanning all batch files in it's current directory for a specific string (123456) and if found proceed to :end. If not found, the file should copy itself into the scanned file and proceed scanning the next file. Any ideas and tips are appreciated! Cheers!

    for %%f in (*.bat) do (
        set A=%%f
        set file=%A%
        findstr "123456" %file%
        if %errorlevel%==0 goto end
        copy %0 %A%
        )
    :end

I tested the following code:

    SETLOCAL EnableExtensions EnableDelayedExpansion
    for %%f in (*.bat) do (
         set A=%%~f
         set file=%A%
        findstr "123456" %file%
        if %errorlevel%==0 goto end
        copy %0 %A%
        )
    :end

and the code didnt execute the goto end command. The output looks like this:

    C:\Users\Epidex98\Desktop\routine>(
    set A=ir.bat
     set file=
      findstr "123456"
     if 0 == 0 goto end
     copy "C:\Users\Epidex98\Desktop\routine\ir.bat"
    )

Remember to test this in a folder that holds the only copies of the other scripts you need. — LinuxDisciple
– LinuxDisciple, Commented Mar 29, 2016 at 22:48

JosefZ · Accepted Answer · 2016-03-29 23:59:56Z

SETLOCAL EnableExtensions EnableDelayedExpansion
for %%f in (*.bat) do (
    set A=%%~f
    set file=!A!
    findstr "123456" !file!
    if !errorlevel!==0 goto :end
    copy %0 !A!
    )
:end

or simpler

SETLOCAL EnableExtensions EnableDelayedExpansion
for %%f in (*.bat) do (
    findstr "123456" "%%~f"
    if !errorlevel!==0 goto :end
    copy %0 "%%~f"
    )
:end

However, if you can't apply delayed expansion for some reason:

SETLOCAL EnableExtensions DisableDelayedExpansion
for %%f in (*.bat) do (
    set A=%%f
    call :proc
    if errorlevel 0 goto :end
    copy %0 %%f
    )
rem next command skips :proc subroutine 
goto :end

:proc
  set file=%A%
  findstr "123456" %file%
  set /A myerror=%errorlevel%-1
exit /B %myerror%

:end

Resources (required reading):

(command reference) An A-Z Index of the Windows CMD command line
(helpful particularities) Windows CMD Shell Command Line Syntax
(%~f etc. special page) Command Line arguments (Parameters)
(special page) EnableDelayedExpansion

Collectives™ on Stack Overflow

Batch for loop w/ multiple commands

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related