TypeError: Cannot read property 'get' of undefined on AngularJS

Question

I am new on AngularJS and I got that error. Here is my code:

app.factory('NotificationService', function($http){
    var factory = {};
    factory.getNotificationList = function($http){
        var url = "http://some/url";
        return $http.get(url);
    }
    return factory;
});

app.controller('NotificationListController', function($scope,$http, NotificationService) {
    var notificationList = NotificationService.getNotificationList();
    notificationList.then(function(response){
        console.log(response);
        $scope.notificationData = response.data;
        return response;
    });
});

I am so confuse where my mistake is. The error message is:

TypeError: Cannot read property 'get' of undefined at Object.factory.getNotificationList (http://localhost:63342/EmailNotification/js/email-angular.js:15:21)

$http is declared twice within the factory. For the 2nd declaration, the named parameter for getNotificationList(), you aren't providing an argument to give it a value. — Jonathan Lonowski
– Jonathan Lonowski, Commented Mar 17, 2016 at 3:59

Tushar · Accepted Answer · 2016-03-17 04:01:50Z

3

You are getting this error because $http is undefined in your factory.

You can fix it by passing it to the factory like so:

app.factory('NotificationService', ['$http', function ($http) {
    var factory = {};
    factory.getNotificationList = function() { // Remove the `$http` parameter from here.
        var url = "http://some/url";
        return $http.get(url);
    }
    return factory;
}]);

edited Mar 17, 2016 at 4:01

Tushar

87.4k21 gold badges164 silver badges182 bronze badges

answered Mar 17, 2016 at 4:00

JanR

6,1303 gold badges25 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Anonymous Duck Over a year ago

@twindicated70 accept it as an answer so if someone will encountered the same issue, he can easily check correct one

Paul Nikonowicz Over a year ago

isn't this only necessary if they are minifying the js?

Rajiv Pingale · Accepted Answer · 2016-03-17 04:13:07Z

Simple possible reason is $http is passed twice. When you pass any argument to the function, the closure for those variable changes

see the example here

var a =10;
var b= 20;

var abc = function()
{
      document.getElementById("first").innerHTML = a + b;
}

var pqr = function(a,b)
{
      document.getElementById("second").innerHTML = a + b;
}

abc();
pqr();

In this example, though variable a,b declared, second function pqr() will return NaN, until we pass an argument, explicitly

Collectives™ on Stack Overflow

TypeError: Cannot read property 'get' of undefined on AngularJS

2 Answers 2

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Related