PHP error while getting multiple rows

Question

I am trying to get all rows in database. My code:

$sql = "SELECT * FROM lectors";

$array = array();
while($row =  mysqli_fetch_assoc(mysqli_query($con,$sql))){
    echo $row["name"];
}

While I send request, server doesn't reply. Any ideas?

Do the mysqli_query($con,$sql) as a single step before your while, and the mysqli_fetch_assoc() in the while.... because I'm sure you've never seen a working example or anything in the PHP Docs that combines everything inside the while — Mark Baker
– Mark Baker, Commented Feb 3, 2016 at 15:39
@BenPearlKahan, in another php file: $con = mysqli_connect(HOST,USER,PASS,DB) or die('Unable to Connect'); — Roman Svyatnenko
– Roman Svyatnenko, Commented Feb 3, 2016 at 15:39
php.net/manual/en/mysqli.error.php and use that against your query — Funk Forty Niner
– Funk Forty Niner, Commented Feb 3, 2016 at 15:50

Hanky Panky · Accepted Answer · 2016-02-03 15:55:18Z

5

while($row =  mysqli_fetch_assoc(mysqli_query($con,$sql))){

This is a never ending loop, your query will execute fine every time and loop will never terminate.

Need I say further?

It is only as good as

while(true)
{
   // keep querying my database until i run out of resources
}

Execute the query first and loop over its result only.

And Oh,

While I send request, server doesn't reply

Because, as i said; It is busy running in a circle, has no time to reply.

edited Feb 3, 2016 at 15:55

answered Feb 3, 2016 at 15:41

Hanky Panky

46.9k9 gold badges76 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Roman Svyatnenko Over a year ago

But my code works fine with loop. My problem was in lines, see below answer.

Hanky Panky Over a year ago

Nope it doesn't. If you did understand, that answer speaks this same language. Just that it provides a copy paste solution without much of an explanation so it fixes your problem but you still don't know what the problem was :)

ckimbrell · Accepted Answer · 2016-02-03 15:44:06Z

1

Try to put the query in a line by itself, such as...

$sql = "SELECT * FROM lectors";
$array = array();
$res = mysqli_query($con,$sql);
while($row =  mysqli_fetch_assoc($res)){
    echo $row["name"];
}

Doing it in the method you are above will result in each execution of the loop executing the database query.

edited Feb 3, 2016 at 15:44

answered Feb 3, 2016 at 15:40

ckimbrell

5273 silver badges9 bronze badges

1 Comment

Jay Blanchard Over a year ago

Why should the OP "try this"? A good answer will always have an explanation of what was done and why it was done that way, not only for the OP but for future visitors to SO.

Collectives™ on Stack Overflow

PHP error while getting multiple rows

2 Answers 2

2 Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Related