Angular $http.get not return data

Question

I created a helper service to wrap the $http.get.

self.apiGet = function (url, success, failure, always) {
           
            $http.get(url)
                .then(function (result) {
                    success(result);
                    if (always != null)
                        always();
                }, function (result) {
                    if (failure != null) {
                        failure(result);
                    }
                    else {

                    }
                    if (always != null)
                        always();
                });
        }

In my controller class, the data is not returned to the view when calling getData(val). the data is returned from the api when I debug it.

 $scope.getData = function (val) {
        return helper.apiGet(url,
            function (result) {
                return result.data;
            });
    };

they are not in the same domain. I don't think it is csrf related as I can see the data. I just can't figure out why it is returned to the view. — Chen
– Chen, Commented Jan 1, 2016 at 10:05
You mean you have cors enabled in the other app (the api)? csrf and cors are different but I guess you know that already. — masnun
– masnun, Commented Jan 1, 2016 at 10:07
You need to show your view code so we understand your intentions. But I suspect that you are over thinking this ... — o4ohel
– o4ohel, Commented Jan 1, 2016 at 10:09
Well, your apiGet() function doesn't return anything. You're reinventing promises poorly. Your apiGet() function doesn't do anything that promises don't allow to do natively, and in a standard way. Read this article, to understand the traps of promises that you fell into: blog.ninja-squad.com/2015/05/28/angularjs-promises — JB Nizet
– JB Nizet, Commented Jan 1, 2016 at 10:09

dfsq · Accepted Answer · 2016-01-01 10:46:46Z

4

You should just use promises properly. So the service becomes:

self.apiGet = function(url) {
    return $http.get(url).then(function(result) {
        return result.data;
    });
};

... and it's consumed in controller like this:

helper.apiGet(url).then(function(data) {
    $scope.data = data;
});

answered Jan 1, 2016 at 10:46

dfsq

193k26 gold badges244 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Chen Over a year ago

I use Typeahead in my view which requires calling function in my controller, I can't just use the $scope here.

dfsq Over a year ago

Doesn't matter. The point is that you just return promise from the service. Then you use it whatever way you need. In your case you can call function instead of $scope.data = data;.

Collectives™ on Stack Overflow

Angular $http.get not return data

1 Answer 1

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Related