Javascript object returns undefined

Question

var movies = 
[
{name: "In Bruges", rating:"4.7", seen:false},
{name: "Frozen", rating: "4.5", seen:true},
{name: "Lion King", rating:"5", seen:true},
]


for (var i = 0; i < movies.length; i++) {
    var result = "You have ";
    if(movies.seen === true){
        result += "watched ";
    }
    else{
        result += "not seen ";
    }
    result += "\"" + movies.name + "\" - ";
    result += movies.rating + " stars"
    console.log(result)
};

You have not seen "undefined" - undefined stars is the result in chrome however you should see You have seen/not seen "movie name" - "rating" stars.

I need to use for loop to print out what each movie I have watched and rating and if I have seen it or not. Question is why is it undefined? Should the code see movies.rating and just substitute the value there? Can some one check my code and help me with my for loop?

Refer array elements with index, if(movies.seen === true) to if(movies[i].seen === true). or use forEach loop. — rajuGT
– rajuGT, Commented Nov 24, 2015 at 19:59
@rajuGT Awesome it worked, adding i to both movies.seen/name/rating made it work. Thanks! — inkplay_
– inkplay_, Commented Nov 24, 2015 at 20:03

Ramanlfc · Accepted Answer · 2015-11-24 19:59:48Z

3

movies is an array movies.seen won't work use movies[i].seen and like wise for other properties

answered Nov 24, 2015 at 19:59

Ramanlfc

8,3541 gold badge21 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user2059983 · Accepted Answer · 2015-11-24 20:00:50Z

1

Change movies.seen, movies.rating and movies.name to movies[i].seen, movies[i].rating, and movies[i].name.

answered Nov 24, 2015 at 20:00

user2059983

Comments

R. Oosterholt · Accepted Answer · 2015-11-24 20:01:20Z

Use index to access item of array; e.g. movies[i]:

for (var i = 0; i < movies.length; i++) {
    var result = "You have ";
    if(movies[i].seen === true){
        result += "watched ";
    }
    else{
        result += "not seen ";
    }
    result += "\"" + movies[i].name + "\" - ";
    result += movies[i].rating + " stars"
    console.log(result)
}

Or you could store the array item in a variable and use it like this:

for (var i = 0; i < movies.length; i++) {
    var movie = movies[i];
    var result = "You have ";
    if (movie.seen) {
        result += "watched ";
    }
    else {
        result += "not seen ";
    }
    result += '"' + movie.name + '" - ';
    result += movie.rating + " stars";
    console.log(result);
}

Rodmentou · Accepted Answer · 2015-11-24 20:03:46Z

Here is a working Plunker for you to see it working. :)

var movies = 
[
{name: "In Bruges", rating:"4.7", seen:false},
{name: "Frozen", rating: "4.5", seen:true},
{name: "Lion King", rating:"5", seen:true},
]


for (var i = 0; i < movies.length; i++) {
    var result = "You have ";
    if(movies[i].seen === true){
        result += "watched ";
    }
    else{
        result += "not seen ";
    }
    result += "\"" + movies[i].name + "\" - ";
    result += movies[i].rating + " stars"
    alert(result)
}

You were trying to access properties of movies called seem, name and rating, but movies has 3 objects indexed from 0 to 2.

Zohaib Ijaz · Accepted Answer · 2015-11-24 20:04:03Z

0

You are using movies inside loop and movies do not contain those properties. And it is allways safe to use forEach loop while iterating arrays

Do something like

movies.forEach(function(movie){
var result = "You have ";
    if(movie.seen === true){
        result += "watched ";
    }
    else{
        result += "not seen ";
    }
    result +=  movie.name + " - ";
    result += movie.rating + " stars";
    console.log(result);

});

answered Nov 24, 2015 at 20:04

Zohaib Ijaz

23k7 gold badges42 silver badges63 bronze badges

Comments

Nina Scholz · Accepted Answer · 2015-11-24 20:08:05Z

I suggest to use a little other approach to iterate over the array and for the check if a movie has been seen.

var movies = [
    { name: "In Bruges", rating: "4.7", seen: false },
    { name: "Frozen", rating: "4.5", seen: true },
    { name: "Lion King", rating: "5", seen: true },
];

movies.forEach(function (movie) {
    var result = "You have ";            
    result += movie.seen ? "watched " : "not seen ";            
    result += "\"" + movie.name + "\" - ";
    result += movie.rating + " stars"
    document.write(result + '<br>');
});

Collectives™ on Stack Overflow

Javascript object returns undefined

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Related