Swift adding button into view programatically with action

Question

I am trying to add button to the programatically created view that I add to main view. I can't make action to work on a button. This is what I tried so far:

itemView = UIImageView(frame:CGRect(x:0, y:0, width:240, height:375))
itemView.backgroundColor = UIColor(red: 255.0/0.0, green: 255.0/0.0, blue: 255.0/0.0, alpha: 0.05)
itemView.contentMode = .Center

buttonConnect = UIButton(frame: CGRect(x:0, y:335, width:120, height:40))
buttonConnect.backgroundColor = UIColor(red: 0.8, green: 0.6, blue: 0.2, alpha: 1.0)
buttonConnect.setTitle("Connect", forState: .Normal)
buttonConnect.tag = 3
buttonConnect.addTarget(itemView, action: "btnConnectTouched:", forControlEvents:.TouchDown)
itemView.addSubview(buttonConnect)

self.addSubview(itemView)

Method on button click looks like this:

func btnConnectTouched(sender:UIButton!)
{
    print("button connect touched")
}

Can someone advice what is the problem? Thanks!

Muneeba · Accepted Answer · 2015-11-24 12:33:05Z

5

I don't understand why you are adding a button inside a UIImageView. Even this is what you need, take a UIView and then put all other controls inside it. The reason your button is not clicking is that you have put it inside a UIImageView and for UIImageView , default value for userInteractionEnabled is false. so you need to enable it i.e.

 itemView.userInteractionEnabled = true;

Also set button target to 'self' rather than itemView.

answered Nov 24, 2015 at 12:33

Muneeba

1,77610 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Bob Over a year ago

This is a great answer. Thanks a lot! I changed UIImageView to UIView and also changed target to self and it works

Manuel · Accepted Answer · 2015-11-24 12:22:38Z

2

Try change the tarjet and the event

buttonConnect.addTarget(itemView, action: "btnConnectTouched:", forControlEvents:.TouchDown)

into

buttonConnect.addTarget(self, action: "btnConnectTouched:", forControlEvents:. TouchUpInside)

edited Nov 24, 2015 at 12:22

answered Nov 24, 2015 at 12:20

Manuel

1,70513 silver badges18 bronze badges

Comments

tuledev · Accepted Answer · 2015-11-24 12:17:19Z

1

You are wrong at the target:

// buttonConnect.addTarget(itemView, action: "btnConnectTouched:", forControlEvents:.TouchDown)
    // using
    buttonConnect.addTarget(self, action: "btnConnectTouched:", forControlEvents:.TouchDown)
    // or buttonConnect.addTarget(self, action: "btnConnectTouched:", forControlEvents:.TouchUpInside)

answered Nov 24, 2015 at 12:17

tuledev

10.3k4 gold badges33 silver badges50 bronze badges

2 Comments

tuledev Over a year ago

@bla0009 did you change itemView to self?

Bob Over a year ago

@anthu yes, and still nothing happens on button click

Nisha Salim · Accepted Answer · 2015-11-24 12:24:33Z

override func viewDidLoad() {
    super.viewDidLoad()
    // Do any additional setup after loading the view, typically from a nib.

    let buttonConnect = UIButton()      
    buttonConnect = UIButton(frame: CGRect(x:0, y:335, width:120, height:40))
    buttonConnect.backgroundColor = UIColor(red: 0.8, green: 0.6, blue: 0.2, alpha: 1.0)
    buttonConnect.setTitle("Connect", forState: .Normal)
    buttonConnect.tag = 3
    buttonConnect.addTarget(self, action: "btnConnectTouched:", forControlEvents: .TouchUpInside)       
    self.view.addSubview(buttonConnect)
}

func btnConnectTouched(sender: UIButton!) {
     print("button connect touched");
}

change forControlEvents:.TouchDown to forControlEvents: .TouchUpInside

Graeme K · Accepted Answer · 2015-11-24 12:23:14Z

0

try buttonConnect.addTarget(itemView, action: "btnConnectTouched", forControlEvents:.TouchUpInside) without the : after "btnConnectTouched"

answered Nov 24, 2015 at 12:23

Graeme K

898 bronze badges

Comments

Avinash Jadhav · Accepted Answer · 2015-11-24 12:55:26Z

If you can make following two changes in your code, it will work.

Replace UIImageView with UIView for itemView type and
Replace self.addSubview(itemView) with self.view.addSubview(itemView)

Your final code should look like....

override func viewDidLoad() {
    super.viewDidLoad()
    // Do any additional setup after loading the view, typically from a nib.

    var itemView = UIView(frame:CGRect(x:0, y:0, width:240, height:375))
    itemView.backgroundColor = UIColor(red: 255.0/0.0, green: 255.0/0.0, blue: 255.0/0.0, alpha: 0.05)
    itemView.contentMode = .Center

    var buttonConnect = UIButton(frame: CGRect(x:0, y:335, width:120, height:40))
    buttonConnect.backgroundColor = UIColor(red: 0.8, green: 0.6, blue: 0.2, alpha: 1.0)
    buttonConnect.setTitle("Connect", forState: .Normal)
    buttonConnect.tag = 3
    buttonConnect.addTarget(self, action: "btnConnectTouched:", forControlEvents:.TouchDown)


    itemView.addSubview(buttonConnect)

    self.view.addSubview(itemView)

}

func btnConnectTouched(sender:UIButton!)
{
    print("button connect touched")
}

Try this one.... It's working for me....

Collectives™ on Stack Overflow

Swift adding button into view programatically with action

6 Answers 6

1 Comment

Comments

2 Comments

1 Comment

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

Comments

2 Comments

1 Comment

Comments

Comments

Related