i'm getting an Uncaught TypeError: Cannot set property 'onclick' of null? [duplicate]

Question

i'm getting uncaught type error of: Uncaught TypeError: Cannot set property 'onclick' of null

<!DOCTYPE html>
<html>
    <head>
        <title>dice app</title>
        <script src="widget.js"></script>
    </head>
    <body>
        <button id="button">Roll Dice</button>
    </body>
</html>

js code:

var button = document.getElementById("button");

button.onclick = function() {// error
    var print = dice.roll();
    printNumber(print);
};

for one thing, you dice isn't defined anywhere. The button seems fine. — nem035
– nem035, Commented Nov 19, 2015 at 16:00
you probably need to put this code in an "onload" function, because if you put it plain in the window root, it is probably going to be executed before the page is completely loaded and then the button object doesn't exist — RiccardoC
– RiccardoC, Commented Nov 19, 2015 at 16:01
A better duplicate is probably Why does jQuery or a DOM method such as getElementById not find the element? — Felix Kling
– Felix Kling, Commented Nov 19, 2015 at 16:04

j08691 · Accepted Answer · 2015-11-19 16:00:46Z

5

You're executing your JavaScript before the elements exist. Either move your code to the end of the page or put it within an onload handler.

Ex:

<!DOCTYPE html>
<html>
    <head>
        <title>dice app</title>
    </head>
    <body>
        <button id="button">Roll Dice</button>
        <script src="widget.js"></script>
    </body>
</html>

answered Nov 19, 2015 at 16:00

j08691

208k33 gold badges269 silver badges281 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Danny H · Accepted Answer · 2015-11-19 16:00:50Z

2

Move your script after the button in the HTML. Currently the script is being evaluated but the HTML element hasn't been created yet.

answered Nov 19, 2015 at 16:00

Danny H

3662 silver badges7 bronze badges

Collectives™ on Stack Overflow

i'm getting an Uncaught TypeError: Cannot set property 'onclick' of null? [duplicate]

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related