Error reading from xml file in java

Question

i have the following xml:

<Triangle>
    <Color>
        <Red>r-0</Red>
        <Green>g-0</Green>
        <Blue>b-255</Blue>
    </Color>
    <FillColor>
        <Red>r-0</Red>
        <Green>g-0</Green>
        <Blue>b-255</Blue>
    </FillColor>
    <Position>
        <X>x-12</X>
        <Y>y-12</Y>
    </Position>
    <properties>
        <Y1>v-13.0</Y1>
        <X1>v-12.0</X1>
        <Y2>v-15.0</Y2>
        <X2>v-14.0</X2>
    </properties>
</Triangle>

and i want to get values from nodes for example: the node Y1 has the element v-13.0

i used this method:

Map<String, Double> m = new HashMap<String, Double>();
File xmlFile = new File("Data.xml");
DocumentBuilderFactory docFactory = DocumentBuilderFactory.newInstance();
DocumentBuilder docBuilder = docFactory.newDocumentBuilder();
Document xmlDoc = docBuilder.parse(xmlFile);

NodeList list = xmlDoc.getElementsByTagName("properties");

Node node1 = list.item(0);
Element element1 = (Element) node1;
//Y1
String s = element1.getElementsByTagName("Y1").item(0).getTextContent();
String[] temp = s.split("[-]");
m.put("Y1", Double.parseDouble(temp[1]));

//X1
s =element1.getElementsByTagName("X1").item(0).getTextContent();
temp = s.split("[-]");
m.put("X1", Double.parseDouble(temp[1]));

//Y2
s =element1.getElementsByTagName("Y2").item(0).getTextContent();
temp = s.split("[-]");
m.put("Y2", Double.parseDouble(temp[1]));

//X2
s =element1.getElementsByTagName("X2").item(0).getTextContent();
temp = s.split("[-]");
m.put("X2", Double.parseDouble(temp[1]));

when i used this method to get elements of the X1, Y1, X2, Y2 in properties tag it gives me null pointer exception in the line String s = element1.getElementsByTagName("Y1").item(0).getTextContent() but when i used the same method to get elements of X, Y in the position tag it worked. what is the solution?

Works fine for me. Have you doube-checked that Y1 is present in your input XML? — Tom Mac
– Tom Mac, Commented Oct 29, 2015 at 11:07
Copied it exactly as above and run it, no exceptions, output of 'm' = "{X1=12.0, X2=14.0, Y1=13.0, Y2=15.0}" I can only assume you are pointing at a dodgy xml file. — Ross Drew
– Ross Drew, Commented Oct 29, 2015 at 11:08
The only thing I could see as a problem is if the xml file is wrong. As I said, the above works fine for me and everyone else. — Ross Drew
– Ross Drew, Commented Oct 29, 2015 at 11:46

bvdb · Accepted Answer · 2015-10-29 12:00:15Z

1

Works fine on my computer.

map : {Y1=13.0, X1=12.0, Y2=15.0, X2=14.0}

Is it possible that you are testing with the wrong xml file ? Hint: try specifying the full absolute system path to your "data.xml" file. You may find out that java used a different file.

PS: not really relevant, but it's better to use Double.valueOf(String) to convert the strings. The parseDouble method results in a primitive double, which requires java to perform auto-boxing. The valueOf on the other hand immediately creates a wrapper Double object (no auto-boxing necessary).

Another thing to check: xml tags are case sensitive. According to your java code, your <properties> tag has to be in lower-case. Your code will not work if your xml file contains a <Properties> node instead.

edited Oct 29, 2015 at 12:00

answered Oct 29, 2015 at 11:21

bvdb

25.2k11 gold badges122 silver badges135 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

bvdb Over a year ago

@Mark Mamdouh and you are testing with the exact same file ? or is the content different ? (xml is case sensitive, so that could also be it) The <properties> tag has to be in lower-case.

Mark Mamdouh Over a year ago

i got the problem, i have <properties> tag for all shapes i have that's why it gives me error , thank you @bvdb

Nemaky · Accepted Answer · 2015-10-29 11:50:51Z

0

i change String[] temp ;//= s.split("[-]");

to String[] temp = s.split("[-]");

and work fine with me

answered Oct 29, 2015 at 11:50

Nemaky

811 silver badge4 bronze badges

4 Comments

bvdb Over a year ago

indeed, that's also the thing I changed to make it running. So, in my opinion there's nothing wrong with the java code.

Mark Mamdouh Over a year ago

@Nemaky i have your code in my code it is a mistake in the post, i edited it

Nemaky Over a year ago

can you write the exception here and check the list length

Mark Mamdouh Over a year ago

i got the problem, i have <properties> tag for all shapes i have that's why it gives me error , thank you @Nemaky

Mark Mamdouh · Accepted Answer · 2015-11-25 07:17:48Z

0

i have many shapes in my XML file and every shape has properties tag that's why it gives me error

answered Nov 25, 2015 at 7:17

Mark Mamdouh

1695 silver badges17 bronze badges

Collectives™ on Stack Overflow

Error reading from xml file in java

3 Answers 3

2 Comments

4 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

4 Comments

Comments

Related