Concatenate javascript variable with html to create href

Question

I am trying to create a href with html(), however the output is not correct. What is wrong with this jquery code?

$('#tag_modal').find('.modal-body').html("<a href='/companies/explore-companies?tags='"+data.results['tag_id']+">test</a>");

Output:

<div class="modal-body"><a 5="" href="/companies/explore-companies?tags=">test</a></div>

are you missing a ' in ">test</a>" ?

Paul
– Paul

2015-08-05 00:29:18 +00:00
Commented Aug 5, 2015 at 0:29 — Paul
– Paul, Commented Aug 5, 2015 at 0:29
@Paul it's there, just in wrong place

charlietfl
– charlietfl

2015-08-05 00:30:16 +00:00
Commented Aug 5, 2015 at 0:30 — charlietfl
– charlietfl, Commented Aug 5, 2015 at 0:30

Musa · Accepted Answer · 2015-08-05 00:30:36Z

4

You're closing the attribute before the tag id, close it after

$('#tag_modal').find('.modal-body').html("<a href='/companies/explore-companies?tags="+data.results['tag_id']+"'>test</a>");

answered Aug 5, 2015 at 0:30

Musa

97.9k17 gold badges123 silver badges144 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ghazgkull · Accepted Answer · 2015-08-05 00:33:34Z

3

Your quotes are wrong. Try:

$('#tag_modal').find('.modal-body')
    .html('<a href="/companies/explore-companies?tags='+data.results['tag_id']+'">test</a>');

edited Aug 5, 2015 at 0:33

answered Aug 5, 2015 at 0:29

Ghazgkull

1,0001 gold badge6 silver badges17 bronze badges

Comments

benjarwar · Accepted Answer · 2015-08-05 00:29:22Z

Try creating your anchor element first:

var $anchor = $("<a href='/companies/explore-companies?tags='"+data.results['tag_id']+"'>test</a>");

And then appending it to your div:

$('#tag_modal').find('.modal-body').append($anchor);

That way you're breaking the process into discrete steps (first create the element, second append it to the DOM).

Edit: as others have mentioned, you also need to close the href value, with a single quote, before you close the tag with the greater-than symbol.

Collectives™ on Stack Overflow

Concatenate javascript variable with html to create href

3 Answers 3

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Related