Custom Attribute with optional parameter

Question

I have this Custom Attribute (Custom MVC Authorization):

public class CustomAuthorizeAttribute : AuthorizationFilterAttribute
{
    public string Users { get; set; } //its always null!

    public override void OnAuthorization(HttpActionContext actionContext)
    {
        string user = Thread.CurrentPrincipal.Identity.Name.Split('\\')[1];

        AdProxy AdProxy = new AdProxy();

        if (!AdProxy.IsUserInGroup(user, Users))
        {
            actionContext.Response = new HttpResponseMessage(HttpStatusCode.Unauthorized);

        }
    }

}

I use it like this:

[CustomAuthorizeAttribute(Users = "Admin")]

But on debugging the value of "Users" is always null. Any idea?

First I think that you forget that Users in your class is not base.Users. Probably you are missing the constructor with optional parameter which overrides the base.Users property or just fill it through your parent constructor. — Ognyan Dimitrov
– Ognyan Dimitrov, Commented Jul 1, 2015 at 14:09
What do you mean? can you write the ctor plz? According to this link: dotnet-tricks.com/Tutorial/mvc/… I dont have to add a ctor and fill the parameters — Guy Z
– Guy Z, Commented Jul 1, 2015 at 14:13

Narek · Accepted Answer · 2015-07-01 16:08:35Z

1

If you are using .net Framework 4.5.1 change to 4.5 and it should work.

class CustomAuthorizeAttribute : AuthorizeAttribute
{
    public string Users { get; set; }
    public override void OnAuthorization(AuthorizationContext filterContext)
    {

        base.OnAuthorization(filterContext);
    }
}

answered Jul 1, 2015 at 16:08

Narek

4492 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Hanlet Escaño · Accepted Answer · 2015-07-01 21:11:22Z

0

Try this:

 public class CustomAuthorizeAttribute : AuthorizeAttribute
 { ... }

edited Jul 1, 2015 at 21:11

Hanlet Escaño

17.4k10 gold badges54 silver badges76 bronze badges

answered Jul 1, 2015 at 14:23

Ognyan Dimitrov

6,2832 gold badges53 silver badges75 bronze badges

1 Comment

Ognyan Dimitrov Over a year ago

It should work now. There was misspell in AuthorizeAttribute - There is no AuthorizationFilterAttribute. Only Authorize attribute which contains in itself Users property.

Collectives™ on Stack Overflow

Custom Attribute with optional parameter

2 Answers 2

Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Related