Unable to get AngularJS controller object

Question

In my non-angular code I am getting controller object through following code

var controllerElement = angular.element('[ng-controller="' + controllerName + '"]');
var controller = controllerElement.controller();

It was working perfectly until day before yesterday when instead of controller object controller object has some $get.h {}

Following code returns correct controller object but there is a scenario in which angular is throwing exception:

var $controller = injector.get("$controller");
var controller = $controller(controllerName, { $scope: scope });

Could you please help me find figure out what is the problem with former approach i.e. controllerElement.controller();

EDIT: Found another issue with latter approach that it instantiates a new controller object instead of returning the original one associated with the element.

what is the value returned by controllerElement.length

Arun P Johny
– Arun P Johny

2015-05-20 06:08:51 +00:00
Commented May 20, 2015 at 6:08 — Arun P Johny
– Arun P Johny, Commented May 20, 2015 at 6:08
contrllerElement has length 1 i.e. correct element is found

Haris
– Haris

2015-05-20 07:18:05 +00:00
Commented May 20, 2015 at 7:18 — Haris
– Haris, Commented May 20, 2015 at 7:18

topless · Accepted Answer · 2015-06-29 07:28:20Z

1

I would strongly recommend not to mix angular code with external JS. Every time you are calling a Controller, it will created indeed a new object, but as far as I understood from your question, you probably want to do some manipulation in it or its data. For persistent data across controllers or states of your application you should use a Service or a Factory, and manipulating it should happen in it, or from a Controller not some random JS somewhere.

answered Jun 29, 2015 at 7:28

topless

8,23111 gold badges60 silver badges87 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Unable to get AngularJS controller object

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related