SQL Variable Inserting INSIDE mysql_query

Question

I am trying to make a price slider with PHP and SQL , but i have a problem when i have some problem in this code

$query = mysql_query("SELECT * FROM price WHERE phone_price BETWEEN" .$from. "AND" .$to. );
while($row = mysql_fetch_array($query)){
print $row['phone_name'];
print $row['phone_price'];
print '';
}

I want to run the SQL query like SELECT * FROM price WHERE phone_price BETWEEN 300 AND 500

I am making a beta version therefore i am accepting the $from and $to values from <input> , i think i am making the error in inserting the variable in mysql_query .

THE ERROR -Warning: mysql_fetch_array() expects parameter 1 to be resource, boolean given in C:\xampp\htdocs\login\slide\slide.php on line 28

Kamnibula · Accepted Answer · 2015-04-26 08:17:34Z

4

You have a mistake in your query. Spaces needed after BETWEEN and AND. Otherwise php reads your query like ...BETWEEN123AND1234.... And you should better use quotes to place vars:

$query = mysql_query("SELECT * FROM `price` WHERE `phone_price` BETWEEN '".$from."' AND '".$to."'");

edited Apr 26, 2015 at 8:17

answered Apr 26, 2015 at 7:59

Kamnibula

887 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

pavel Over a year ago

Don't use quotes around number.

Wasim Ahmad Over a year ago

but why do you put things inside quotes 'price' ??

Wasim Ahmad Over a year ago

$query = mysql_query("SELECT * FROM price WHERE phone_price BETWEEN " .$from. " AND " .$to ); i just added spaces and everything worked

Kamnibula Over a year ago

Well quotes around number are not necessary, but it make code more structured. But spaces between BETWEEN and AND are necessary.

Wasim Ahmad Over a year ago

can you tell how can i get the value of $from and $to , through a slider

|

TomerM · Accepted Answer · 2015-04-26 09:13:03Z

Use PDO build-In object. mysql_ functions were deprecated.

Initialize connection.

$dsn = "mysql:host=localhost;dbname=my_database";
$pdo = new PDO($dsn, $login, $password);

Use prepare statement.

$sh = $pdo->prepare("SELECT * FROM price WHERE phone_price BETWEEN :from AND :to");

Bind values and value types.

$sh->bindParam(':from',$from,PDO::PARAM_INT);
$sh->bindParam(':to',$to,PDO::PARAM_INT);

Fetch results into assoc array.

$res = $sh->fetch_all(PDO::FETCH_ASSOC);

Collectives™ on Stack Overflow

SQL Variable Inserting INSIDE mysql_query

2 Answers 2

7 Comments

Use PDO build-In object. mysql_ functions were deprecated.

Initialize connection.

Use prepare statement.

Bind values and value types.

Fetch results into assoc array.

Good Luck

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Use PDO build-In object. mysql_ functions were deprecated.

Initialize connection.

Use prepare statement.

Bind values and value types.

Fetch results into assoc array.

Good Luck

Comments

Related