Will null instanceof SomeClass return false or throw a NullPointerException?
8 Answers
No, a null check is not needed before using instanceof.
The expression x instanceof SomeClass is false if x is null.
The Java 11 Language Specification expresses this concisely in section 15.20.2, "Type comparison operator instanceof". (Java 17 expresses this less concisely, after the introduction of instanceof pattern matching.)
"At run time, the result of the
instanceofoperator istrueif the value of the RelationalExpression is notnulland the reference could be cast to the ReferenceType without raising aClassCastException. Otherwise the result isfalse."
So if the operand is null, the result is false.
11 Comments
try it because current behavior is not the same as guaranteed behavior.Effective Java - amazon.com/Effective-Java-Edition-Joshua-Bloch/dp/0321356683Very good question indeed. I just tried for myself.
public class IsInstanceOfTest {
public static void main(final String[] args) {
String s;
s = "";
System.out.println((s instanceof String));
System.out.println(String.class.isInstance(s));
s = null;
System.out.println((s instanceof String));
System.out.println(String.class.isInstance(s));
}
}
Prints
true
true
false
false
JLS / 15.20.2. Type Comparison Operator instanceof
At run time, the result of the
instanceofoperator istrueif the value of the RelationalExpression is notnulland the reference could be cast to the ReferenceType without raising aClassCastException. Otherwise the result isfalse.
API / Class#isInstance(Object)
If this
Classobject represents an interface, this method returnstrueif the class or any superclass of the specifiedObjectargument implements this interface; it returnsfalseotherwise. If thisClassobject represents a primitive type, this method returnsfalse.
8 Comments
s is just an object reference variable. It may refer an actually existing object("") or it may refer a(the) null literal reference.null isn't string data, no matter what variable is pointing to it. s instanceof String is not the same as field.getType().equals(String.class), for example.s instanceof String the s gets replaced with the actual value, so that would become "" instanceof String and null instanceof String. Thinking about it like this may make more sense.Just as a tidbit:
Even (((A)null)instanceof A) will return false.
(If typecasting null seems surprising, sometimes you have to do it, for example in situations like this:
public class Test
{
public static void test(A a)
{
System.out.println("a instanceof A: " + (a instanceof A));
}
public static void test(B b) {
// Overloaded version. Would cause reference ambiguity (compile error)
// if Test.test(null) was called without casting.
// So you need to call Test.test((A)null) or Test.test((B)null).
}
}
So Test.test((A)null) will print a instanceof A: false.)
P.S.: If you are hiring, please don't use this as a job interview question. :D
1 Comment
No, a null check is not needed before calling instanceof. It always returns false if its value is null.
As per Java Language Specification for comparison using instanceof.
At run time, the result of the instanceof operator is true if the value of the RelationalExpression is not null and the reference could be cast to the ReferenceType without raising a ClassCastException. Otherwise the result is false
Hence we can infer that java has something called null type also, and this null type is checked in instanceof operator which obviously returns false because it is expecting a specific type.
There are two kinds of types in the Java programming language: primitive types and reference types. As per Java Specification on types and value
There is also a special null type, the type of the expression null, which has no name. Because the null type has no name, it is impossible to declare a variable of the null type or to cast to the null type. The null reference is the only possible value of an expression of null type. The null reference can always undergo a widening reference conversion to any reference type.
From Java 14 onwards and esp. in LTS Java 17 we have an enhanced instanceof. We have pattern matching feature which performs casts after type comparisons.
Example
public static void main(String[] args) {
Object testObject = "I am a string";
List<Object> testList = null;
if (testList instanceof List) {
System.out.println("instance of list");
} else {
System.out.println("null type");
}
//Enhanced instanceof with type conversion - tested with JDK 17
if (testObject instanceof String str) {
System.out.println(str.toUpperCase());
}
}
Output
null type
I AM A STRING
Comments
- null check is not needed before instanceof
- null check is not needed after instanceof that validates to true
The following are null-safe:
if(couldbenull instanceof Comparable comp){
return comp.compareTo(somethingElse);
}
//java < 14
if(couldbenull instanceof Comparable){
return ((Comparable)couldbenull).compareTo(somethingElse);
}
Comments
The instanceof operator does not need explicit null checks, as it does not throw a NullPointerException if the operand is null.
At run time, the result of the instanceof operator is true if the value of the relational expression is not null and the reference could be cast to the reference type without raising a class cast exception.
If the operand is null, the instanceof operator returns false and hence, explicit null checks are not required.
Consider the below example,
public static void main(String[] args) {
if(lista != null && lista instanceof ArrayList) { //Violation
System.out.println("In if block");
}
else {
System.out.println("In else block");
}
}
The correct usage of instanceof is as shown below,
public static void main(String[] args) {
if(lista instanceof ArrayList){ //Correct way
System.out.println("In if block");
}
else {
System.out.println("In else block");
}
}
instanceofchecks fornullto implement a very tight Javaequals()implementation that reads way cleaner than those I see auto-generated by Eclipse and IntelliJ: stackoverflow.com/a/75402885/501113