C++ pointers and arrays

Question

I have a problem with dynamic array.

In header file class i have this:

class CTerrain
{
    ...
    CRock *rocks;
int numRocks;//=0
    ...
}

and in cpp i have this:

void CTerrain::Create()
{
    numRocks = 0;
    int NUM_ROCKS = rand()%10+1;
        for(int i=0;i<NUM_ROCKS;i++)
        {
            rocks = new CRock;
            numRocks++;
            ...
        }
 }
 void CTerrain::Render()
 {
     for(int i=0;i<numRocks;i++)
     rocks[i].render();//it works ok when here is 0 instead of 'i'
 }

When I run this code I got error: Unhandled exception at 0x00913aea in OpenGL.exe: 0xC0000005: Access violation reading location 0x1c00001f.

Thanks for any help, I have been trying to resolve this problem for like 4 hours...

EDIT:

Ok, so I changed Create() method to this:

void CTerrain::Create()
{
    numRocks = 0;
    int NUM_ROCKS = rand()%10+1;
    rocks = new CRock[NUM_ROCKS];
        for(int i=0;i<NUM_ROCKS;i++)
        {
        rocks[i].position = ...
            numRocks++;
            ...
        }

and also added delete [] rocks and now it's working.

I still have error after changing to "CRock **rocks". Now it shows up in line: "rocks[i] = new CRock;" Error: Unhandled exception at 0x00293b7a in OpenGL.exe: 0xC0000005: Access violation writing location 0xcdcdcdcd. — Barcio77
– Barcio77, Commented Apr 6, 2015 at 20:30

Cory Kramer · Accepted Answer · 2015-04-06 20:19:38Z

1

Your Create function would be more like

void CTerrain::Create()
{
    int NUM_ROCKS = rand()%10+1;
    rocks = new CRock[NUM_ROCKS];
    numRocks = NUM_ROCKS;
    for(int i=0; i<NUM_ROCKS; i++)
    {
        rocks[i] = CRock{};
    }
}

answered Apr 6, 2015 at 20:19

Cory Kramer

119k19 gold badges176 silver badges232 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

gmoniava · Accepted Answer · 2015-04-06 20:34:41Z

1

Just to add bit of explanation to above answer. Here:

 for(int i=0;i<NUM_ROCKS;i++)
 {
            rocks = new CRock;
            numRocks++;
            ...
 }

What you do is, each time assign new instance of CRock to the pointer rock; thereby losing reference to the old object and creating memory leaks. Use a solution similar suggester by Cyber.

answered Apr 6, 2015 at 20:34

gmoniava

28.9k9 gold badges61 silver badges101 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 12:14:16Z

0

First off, rocks is pointer to CRocks. Your implemenation: rocks[i].render() should be something like this:

rocks = new CRock [x]; (where x is the number of objects of type CRock.)

rocks[i] -> render().

delete rocks[i] // Just be sure to delete.

You may want to reference this for your solution on handling how a dynamic array of objects.

This other reference is good.

edited May 23, 2017 at 12:14

CommunityBot

11 silver badge

answered Apr 6, 2015 at 21:20

penguin2718

4741 gold badge3 silver badges7 bronze badges

2 Comments

Barcio77 Over a year ago

Can it be 'delete [] rocks' or it must bo 'delete rocks[n]'?

penguin2718 Over a year ago

delete [] will delete the entire array. delete rocks[i] will delete just the element 'ith'.

Sly_TheKing · Accepted Answer · 2015-04-06 21:03:15Z

0

rocks = new CRock;

you overwrite CRock* pointer rocks in this line over and over again

Use this

rocks = new CRock[NUM_ROCKS];

edited Apr 6, 2015 at 21:03

answered Apr 6, 2015 at 20:56

Sly_TheKing

5087 silver badges14 bronze badges

Collectives™ on Stack Overflow

C++ pointers and arrays

4 Answers 4

Comments

Comments

2 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

2 Comments

Comments

Linked

Related