Angular pushing into an array gives: TypeError: Cannot read property 'push' of undefined

Question

I am trying to push the details from textbox to an array in AngularJS. But it doesn't work

AppName.factory('sampleFactory', function(){
        var customerdetails=[
                {name:'John Smith', country:'Denmark', worth:'5000000'},
                {name:'John Lewis',country:'England',worth:'10000000'},
                {name:'Rick Evans',country:'America',worth:'6000000'}
            ];

        var factory={};
        factory.getCustomers=function(){
            return customerdetails;
        };

        return factory;
    });

AppName.controller('homeController', function($scope, sampleFactory){
    $scope.customers= sampleFactory.getCustomers();

    $scope.addCustomer = function(){
        $scope.customerdetails.push({
            name:$scope.customerName, 
            country:$scope.customerCountry,
            worth:$scope.customerWorth
        });
    };
});

The page has a button with ng-click="addCustomer". But it doesn't add to the array.

The factory part works fine. I am sure I have made an error in the addCustomer function. Can somebody spot it? Thanks!

Omri Aharon · Accepted Answer · 2015-04-03 10:22:53Z

1

You are using the wrong variable name, it should be $scope.customers:

$scope.addCustomer = function(){
        $scope.customers.push({
            name:$scope.customerName, 
            country:$scope.customerCountry,
            worth:$scope.customerWorth
        });
    };

You mistook it for the variable name of the service.

answered Apr 3, 2015 at 10:22

Omri Aharon

17.1k5 gold badges43 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Angular pushing into an array gives: TypeError: Cannot read property 'push' of undefined

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related