Checking values in this array, JQuery

Question

I have this array (JQuery) where I add all my form's controls, it looks like:

var     name       = $("#name"),
        surname    = $("#surname"),
        address    = $("#address"),
        phone      = $("#phone"),
        photo      = $("#photo"),
        grade      = $("#grade"),
        profession = $("#profession"),
        email      = $('#email'),
        title      = $('#title'),

                    allFields =    $([]).add(name)
                                        .add(surname)
                                        .add(address)
                                        .add(phone)
                                        .add(photo)
                                        .add(grade)
                                        .add(profession)
                                        .add(email)
                                        .add(title)
                                        .add(grade);

I want to check the values of each element into the 'allFields' array with

function checkingFieldsArentEmpty(){

              for (var f in allFields){
                    if(f.val() === null)
                        //if any val is null just return false
                        return false;
                }
                return true;
            }

I need ideas in order to improve the last function. Thanks.

What aspect do you want to improve? Your valid var is unnecessary, just return true at the end. — patrickmcgraw
– patrickmcgraw, Commented May 29, 2010 at 3:25
Isn't f already an jQuery object? allFields[f].val() seems wrong, shouldn't it just be f.val() ? — Felix Kling
– Felix Kling, Commented May 29, 2010 at 3:30

cletus · Accepted Answer · 2010-05-29 03:33:17Z

2

Try:

var names = ["name", "surname", "address", "phone", "photo",
  "grade", "profession", "title"];
var allFields = {}
$.each(names, function(i, name) {
  allFields[name] = $("#" + name).val();
});

and then you can do:

if (allFields.name) { // true if it has a value, false for ""
  ...
}

The way you're doing it is a little convoluted. Do you want an array or a jQuery object?

edited May 29, 2010 at 3:33

answered May 29, 2010 at 3:24

cletus

627k169 gold badges922 silver badges945 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

karim79 · Accepted Answer · 2010-05-29 03:27:30Z

1

You could replace that function with:

function checkingFieldsArentEmpty(){
    return !(allFields.filter(":input[value]").length != allFields.filter(":input").length);
}

answered May 29, 2010 at 3:27

karim79

343k67 gold badges420 silver badges408 bronze badges

3 Comments

Felix Kling Over a year ago

@Felix Guerrero: From the documentation: Selects all input, textarea, select and button elements.

karim79 Over a year ago

@Felix Guerrero - I don't understand, the function in your post applies to all the elements contained within allFields.

Felix Kling Over a year ago

I think that the other Felix thinks that :input only applies to <input> elements.

Felix Kling · Accepted Answer · 2010-05-29 03:33:32Z

1

You could use .reduce():

function checkingFieldsArentEmpty(){
    return allFields.reduce(function(prev, curr, index, array) {
        // for checking for emptiness just add  && cur.val() !== "" 
        return prev && curr.val() !== null; 

    }, true);
}

Btw. using jQuery to create and populate the array seems unnecessary to me.

edited May 29, 2010 at 3:33

answered May 29, 2010 at 3:28

Felix Kling

820k181 gold badges1.1k silver badges1.2k bronze badges

Comments

x1a4 · Accepted Answer · 2010-05-29 03:35:31Z

1

hasEmptyFields = !!$.grep(allFields, function(a) { return a.val() === null; }).length

answered May 29, 2010 at 3:35

x1a4

19.5k5 gold badges42 silver badges40 bronze badges

Collectives™ on Stack Overflow

Checking values in this array, JQuery

4 Answers 4

Comments

3 Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

3 Comments

Comments

Comments

Related