NullPointerException error while using Graphics class in java

Question

I'm completely new to java. I'm trying to write a simple java program that takes the input for coordinates and height,width for a rectangle and draws it. But i'm getting NullPointerException error. Here is my code:

import javax.swing.JFrame;
import java.util.Scanner;
import java.awt.*;
public class shape extends JFrame{
public int x,y,width, height;
public void setxyhw(int f, int g, int h, int i){
  this.x = f;
  this.y = g;
  this.width =h;
  this.height = i;
 }

public shape(){
setTitle("frame1");
setSize(960,960);
setVisible(true);
setDefaultCloseOperation(EXIT_ON_CLOSE);
}
public void paint(Graphics g){

g.drawRect(x,y,height,width);

}


public static void main(String[] args) {
    int a,b,c,d ;
    Scanner in = new Scanner(System.in);
    System.out.println("Input Co-ordinates and widh & height for rectangle");
    a= in.nextInt();
    b=in.nextInt();
    c=in.nextInt();
    d=in.nextInt();

    shape s=new shape();

    s.setxyhw(a,b,c,d);

    s.paint(null);
}

}

If you've done even a little searching on solving a NullPointerException (NPE), you'll know that the most important bit of information that we need is the exception's associated stacktrace and some identification of the line that causes it, something that the stacktrace will tell you, and unfortunately neither of which you've posted here with your question. Please fix this so that we can help you. — Hovercraft Full Of Eels
– Hovercraft Full Of Eels, Commented Mar 7, 2015 at 22:05
OK. Here's the message i got "Exception in thread "main" java.lang.NullPointerException at shape.paint(shape.java:21) at shape.main(shape.java:38)" — Prathmesh Deshmukh
– Prathmesh Deshmukh, Commented Mar 7, 2015 at 22:12

Community · Accepted Answer · 2017-05-23 11:50:45Z

4

Yikes:

s.paint(null);

You're calling paint directly, passing in a null parameter, and then wondering why the method throws a NullPointerException!

Solution:

Don't do this. Never call paint directly. That's for the JVM to do.
Draw in a JPanel's paintComponent method, not directly in the JFrame. Drawing directly in the JFrame can cause unwanted side effects in the drawing of borders and child components, and won't animate smoothly later when you try to do animation.
Call repaint() when you want to repaint your GUI.
Read the Swing graphics tutorials. You can find links to the Swing tutorials and other Swing resources here: Swing Info.

edited May 23, 2017 at 11:50

CommunityBot

11 silver badge

answered Mar 7, 2015 at 22:06

Hovercraft Full Of Eels

286k25 gold badges267 silver badges391 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Alexander Over a year ago

why should he not call paint directly on his own class? Its shape s=new shape(); s.paint() we're talking about.

Hovercraft Full Of Eels Over a year ago

@Alexander: because where would he get a viable Graphics object? The Graphics object should be given to you from the JVM, in the paintComponent method. The only exception I can think of is if you want to draw a component onto a BufferedImage, and then you'd use the Graphics object obtained from the BufferedImage to do this.

MadProgrammer Over a year ago

@alexander paint is a public defined by the class hierarchy (Defined by Window) to honor the requirements of the paint subsystem, a system which doesn't involve user or developer interaction. The method will be called automatically by the paint subsystem when it wants something painted. In general practice, you should never need to call it manually

Jens · Accepted Answer · 2015-03-07 22:06:05Z

2

You have null as Parameter at s.paint(null); and call g.drawRect(x,y,height,width); on These object. Parameter for this paint method must be a Graphics object.

answered Mar 7, 2015 at 22:06

Jens

69.6k15 gold badges107 silver badges133 bronze badges

Collectives™ on Stack Overflow

NullPointerException error while using Graphics class in java

2 Answers 2

3 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Related