undefined is not a function error in AngularJS

Question

I am getting the below error is my AngularJs app.

 TypeError: undefined is not a function
    at Scope.$rootScope.shareImageNow (index.controller.js:150)

I am not sure what's the reason after doing some Google research.

controller.js File

app.controller('ViewCtrl', function($rootScope, $state, $scope, $ionicPlatform, $ionicPopup, $ionicLoading, $ionicSlideBoxDelegate, $ionicScrollDelegate, $timeout, Service) {

    var appUrl = "https://play.google.com";

    $rootScope.shareNow = function() {

        var message = "xx";
        var subject = "yy";

        Service.share(message, subject, null, appUrl);

    }

    $rootScope.shareImageNow = function() {

        var imageIndex = 0;

        var imgUrl = $rootScope.itemData[imageIndex]['url'];

        var message = "xx";
        var subject = "yy";

        Service.share(message, subject, imgUrl, appUrl);

    }
});

service.js File:

module.service('Service', function($rootScope, $ionicPlatform, $cordovaSocialSharing) {

    $rootScope.share = function(message,subject,file,link) {

        $ionicPlatform.ready(function() {
            $cordovaSocialSharing
                .share(message, subject,file,link);
        }, false);

    }
}

The error is shown at the below line in controller.js file.

Service.share(message, subject, null, appUrl);

Sorry @DavidGrinberg. I have updated the question now. The error shown is at Service.share(message, subject, null, appUrl); — Purus
– Purus, Commented Feb 5, 2015 at 17:54

Tom · Accepted Answer · 2015-02-05 17:55:10Z

3

You're registering the Service service, but not defining any methods on it.

You're also doing a lot of things with $rootScope, which I'd question why you're doing that.

Anyways, you can define your service as follows, and you will not get the error at Service.share()

module.service('Service', function($ionicPlatform, $cordovaSocialSharing) {

  var share = function(message,subject,file,link) {
      $ionicPlatform.ready(function() {
          $cordovaSocialSharing
              .share(message, subject,file,link);
      }, false);

  };

  return {
      share: share
  }
}

answered Feb 5, 2015 at 17:55

Tom

7,7401 gold badge26 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Purus Over a year ago

Is my way of using a service complety wrong? I have other methods in the service and they all work fine.

Tom Over a year ago

In short, yes, the way you're using the service is completely wrong. $rootScope should almost never need to be used -- that's what services are for.

Purus Over a year ago

Thanks for clarification. This is my first app using Angular. So, if I have more functions in the service, I should be returning all of them at the end as shown. is that so? Can you point me to a tutorial where this is explained? not the official one plz.

Tom Over a year ago

See this jsBin. I tried to demonstrate a little. Notice in service, there are two functions, but I only return one. I'm able to call what I've returned, share(), but unable to call privateFunction, as it is not exposed publicly. www.egghead.io is a good place to start for free AngularJS tutorials

Purus Over a year ago

Thanks @tom. I will check on this.

Collectives™ on Stack Overflow

undefined is not a function error in AngularJS

1 Answer 1

5 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Related