Trouble working with Date object in Javascript

Question

I've written this function to get the current time, like a custom time stamp, and I'm getting an unexpected result. When the current minute is anywhere from "00" to "09", the Javascript method getMinutes() returns from "0" to "9" respectively. I'm using a switch to get this cases and add another "0" in front, but it's not working as expected.

This is my full code:

	function horaActual() {
	  var d = new Date();
	  var dia = '';
	  var hora = '';
	  var minutos = '';

	  switch (d.getDay()) {
	    case 0:
	      dia = 'Dom';
	      break;
	    case 1:
	      dia = 'Lun';
	      break;
	    case 2:
	      dia = 'Mar';
	      break;
	    case 3:
	      dia = 'Mie';
	      break;
	    case 4:
	      dia = 'Jue';
	      break;
	    case 5:
	      dia = 'Vie';
	      break;
	    case 6:
	      dia = 'Sáb';
	      break;
	  };

	  switch (d.getHours()) {
	    case 0, 1, 2, 3, 4, 5, 6, 7, 8, 9:
	      hora = '0' + String(d.getHours());
	      break;
	    default:
	      hora = String(d.getHours());
	      break;
	  };

	  switch (d.getMinutes()) {
	    case 0, 1, 2, 3, 4, 5, 6, 7, 8, 9:
	      minutos = '0' + String(d.getMinutes());
	      break;
	    default:
	      minutos = String(d.getMinutes());
	      break;
	  };

	  return String(dia + ' ' + hora + ':' + minutos);
	}

For example, right now the function returns "Lun 17:5" when it should return "Lun 17:05".

Any comments are welcome!

Use this: momentjs.com

mbx-mbx
– mbx-mbx

2015-02-04 20:08:35 +00:00
Commented Feb 4, 2015 at 20:08 — mbx-mbx
– mbx-mbx, Commented Feb 4, 2015 at 20:08

Joe Enos · Accepted Answer · 2015-02-04 20:09:25Z

2

Switch statements don't work that way in javascript, instead, it would be:

switch (d.getMinutes()) {
    case 0:
    case 1:
    case 2: // etc...
    case 9:
        minutos = '0' + String(d.getMinutes());
        break;
    default:
        minutos = String(d.getMinutes());
        break;
  };

But definitely try to avoid reinventing the wheel - there are plenty of JS date/time libraries out there that will do this work for you.

answered Feb 4, 2015 at 20:09

Joe Enos

40.6k11 gold badges86 silver badges144 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Sumner Evans Over a year ago

Could you give an example of one such JS library?

Joe Enos Over a year ago

Looks like the commenter in your question, Magrangs, suggested a great option - Moment.js. I haven't used that one, but it looks really nice.

mbx-mbx Over a year ago

moment.js is my go to library for anything date related

indubitablee · Accepted Answer · 2015-02-04 20:11:31Z

1

you should use an if statement instead of a switch statement. something like:

if (d.getMinutes() <= 9) {
    minutos = '0' + String(d.getMinutes());
}
else {
    minutos = String(d.getMinutes());
}

answered Feb 4, 2015 at 20:11

indubitablee

8,2262 gold badges27 silver badges49 bronze badges

1 Comment

gdc3000 Over a year ago

Thanks guys for all your anwsers, I'll definetively try momentjs un the future, right now I'm sticking to this solution as I need to include al my code in a single page .

Collectives™ on Stack Overflow

Trouble working with Date object in Javascript

2 Answers 2

3 Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Related