Putting variable inside array[]

Question

So instead of spending much time explaining i will just show you what the problem is, i have this method

public function lockCheck($string)
   {
        $Data = $this->getQuery("SELECT '$string' from settings where id=1");
        if ($Data->num_rows==1)
        {
            while($Row = $Data->fetch_assoc())
            {
                if ($Row[$string]==1)
                {
                    return true;
                }

                else 
                {
                    return false;
                }
            }
        }
   }

And its working perfectly fine if i dont have a parametar and just use 'locked' which is column from my table. But when i try using parametar $string it will always return false.

And this is how i call the method:

$ks->lockCheck("locked")

Any help will be appreciated.

Why the single quotes (') around $string in "SELECT '$string' from settings where id=1"? That's invalid SQL.... It should be backticks (`) if anything — Mark Baker
– Mark Baker, Commented Dec 24, 2014 at 14:36
@MarkBaker technically its not invalid, mysql would select the string 'locked' literally, where id is 1 — andrew
– andrew, Commented Dec 24, 2014 at 14:42

vaso123 · Accepted Answer · 2014-12-24 14:38:04Z

1

In your SQL, when you want to avoid to use a reserved keyword, you need to escape your variable wiht ` character, not single quote.

For example:

$Data = $this->getQuery("SELECT `".$string."` from settings where id=1");

This is also works, but previous I think is more elegant:

$Data = $this->getQuery("SELECT `$string` from settings where id=1");

answered Dec 24, 2014 at 14:38

vaso123

12.4k4 gold badges37 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Chilipepper Over a year ago

Thanks man i always thought it was single quotes instead of `

Collectives™ on Stack Overflow

Putting variable inside array[]

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related