How do I cancel a for loop in java?

Question

The goal of my program is to store a default of 100 Employee objects(but should work with less) to an array after prompting the user input of each employee's name, ssn, and salary with a loop.I then need to output the contents of the array. I am trying to end the loop when the user inputs a 0 when asked for a name, but so far my program seems to loop endlessly.

Driver class:

import java.util.Scanner;

public class EmployeeDemo {

    public static void main(String[] args) {
        // TODO Auto-generated method stub

        Scanner kb = new Scanner(System.in);

        Employee employees[]= new Employee[100];
        String nameTest="";
        for(int i=0;i<100;i++){
            Employee e = new Employee();

        System.out.println("Enter Employee name, Ssn, and salary when prompted");
        System.out.println("When finished type in 0's for each prompt");
        System.out.println("Enter Name: ");
        nameTest=kb.next();
        e.setName(nameTest);
        System.out.println("Enter Ssn: ");
        e.setSsn(kb.next());
        System.out.println("Enter Salary: ");
        e.setSalary(kb.nextDouble());

        if(nameTest=="0"){
            i=100;
        }
        else
            employees[i]=e;
        }

        for(int x=0;x<100;x++){
        employees[x].toString();
        }
    }

}

Methods:

public class Employee extends Person {

    String ssn;
    double salary;
    public String getSsn() {
        return ssn;
    }
    public void setSsn(String ssn) {
        this.ssn = ssn;
    }
    public double getSalary() {
        return salary;
    }
    public void setSalary(double salary) {
        this.salary = salary;
    }
    public Employee() {
        super();
        // TODO Auto-generated constructor stub
    }
    public Employee(String initialName,String initialSsn,double initialSalary) {
        super(initialName);
        ssn=initialSsn;
        salary=initialSalary;
        // TODO Auto-generated constructor stub
    }
    @Override
    public String toString() {
        return "Name: "+getName()+" Ssn: "+getSsn()+" Salary: "+getSalary();
    }
}

Don't use a for loop if you want the user to stop it at will. Use a while loop or a do-while loop. — Hovercraft Full Of Eels
– Hovercraft Full Of Eels, Commented Nov 6, 2014 at 1:49

paxdiablo · Accepted Answer · 2014-11-06 01:50:54Z

2

You should be using equals() to compare strings rather than ==, as in the following line:

if (nameTest == "0")

In order to acheive what you want, you'd use something along the following lines:

System.out.println("Enter Name: ");
nameTest = kb.next();
if (nameTest.equals("0")) break;      // <- add this line here.

This has the advantage of only requiring you to enter 0 for the employee name rather than all three values having to be entered.

answered Nov 6, 2014 at 1:50

paxdiablo

888k242 gold badges1.6k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ankur Singhal · Accepted Answer · 2014-11-06 01:56:00Z

0

Please follow as below

== will test for reference equality only.

.equals() tests for value if equal.

So replace if (nameTest == "0") with if (nameTest.equals("0"))

answered Nov 6, 2014 at 1:56

Ankur Singhal

26.1k17 gold badges91 silver badges128 bronze badges

Comments

RufusInZen · Accepted Answer · 2014-11-06 01:57:13Z

0

First, you are checking an int against a String, which will not work. You should change that to if (nameTest.equals("0") ). Then you can use break to break out of the loop. No need to make i=100.

answered Nov 6, 2014 at 1:57

RufusInZen

2,1991 gold badge20 silver badges27 bronze badges

Comments

vmcloud · Accepted Answer · 2014-11-06 02:10:58Z

0

There is some problem in this code snippet:

if(nameTest=="0"){
    i=100;
}

You should always use "equals" method instead of "==" when judge the value of String to be equal. Accordingly, write the code like this:

if (nameTest.equals("0")) {
    i = 100;
}

answered Nov 6, 2014 at 2:10

vmcloud

6524 silver badges13 bronze badges

Collectives™ on Stack Overflow

How do I cancel a for loop in java?

4 Answers 4

Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Related