Javascript setTimeout at onclick [duplicate]

Question

I am trying to call a javascript function at the onclick of an html element as shown below. But not sure why the below timeout function is not working here.Any idea

onclick="setTimeout(rating(), 3000)"

If you search for (and write about) the actual problem then it's easier to find duplicates - "not working" is not a valid diagnosis. — user2864740
– user2864740, Commented May 11, 2014 at 1:06
stackoverflow.com/questions/7137401/… , stackoverflow.com/questions/4120781/… — user2864740
– user2864740, Commented May 11, 2014 at 1:07
This code hurts my eyes. This is 2014 already, don't use onclick and look at that incorrect use of setTimeout. — Derek 朕會功夫
– Derek 朕會功夫, Commented May 11, 2014 at 1:09
@Derek I am new to javascript.if there is any better way then pls tell — user3541562
– user3541562, Commented May 11, 2014 at 1:13
Have a look at these articles to learn about the different ways to bind event handlers: quirksmode.org/js/introevents.html. — Felix Kling
– Felix Kling, Commented May 11, 2014 at 1:46

Sudhir Bastakoti · Accepted Answer · 2014-05-11 01:04:40Z

4

remove parenthesis, change:

onclick="setTimeout(rating(), 3000)"

to

onclick="setTimeout(rating, 3000)"

or better way would be:

onclick = setTimeout(function() {
    rating();
}, 3000);

answered May 11, 2014 at 1:04

Sudhir Bastakoti

100k15 gold badges163 silver badges169 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2864740 Over a year ago

The "better way" is incorrect - it will spawn the timer first, then pass an (invalid) numeric value to the onclick property.

NoGray · Accepted Answer · 2014-05-11 01:02:55Z

1

onclick="setTimeout(rating, 3000)" // rating without the ()

When you include the parentheses, the function return value is used instead of the function itself.

answered May 11, 2014 at 1:02

NoGray

1,1497 silver badges9 bronze badges

Collectives™ on Stack Overflow

Javascript setTimeout at onclick [duplicate]

2 Answers 2

1 Comment

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Linked

Related