Update table with TextBox values

Question

I have some textboxes that are populated with customer info from a database (name, address) on page load. I want users to be able to simply change this and click a button to update their personal information.

I have the following code that runs on button click:

con.Open();
string query = "UPDATE CustomerInfo SET FirstName=@FirstName, LastName=@LastName, Address=@Address, PostalCode=@PostalCode, PostalName=@PostalName WHERE UserName=@UserName";
SqlCommand cmd = new SqlCommand(query, con);
cmd.Parameters.AddWithValue("@FirstName", SqlDbType.VarChar).Value = txtFirstName.Text;
cmd.Parameters.AddWithValue("@LastName", SqlDbType.VarChar).Value = txtLastName.Text;
cmd.Parameters.AddWithValue("@Address", SqlDbType.VarChar).Value = txtAddress.Text;
cmd.Parameters.AddWithValue("@PostalCode", SqlDbType.Int).Value = txtPostalCode.Text;
cmd.Parameters.AddWithValue("@PostalName", SqlDbType.VarChar).Value = txtPostalName.Text;
cmd.Parameters.AddWithValue("@UserName", SqlDbType.VarChar).Value = UserName;
cmd.ExecuteNonQuery();
con.Close();

This does not work. If I change the textbox to something different and click the button, nothing happens. The table is not updated with the new values, and I get no error messages. However, if I change the Parameter values from for example txtFirstName.Text to "Bob", it successfully updates the FirstName column in my table to Bob.

Not sure what I'm missing, but for some reason using textbox.Text as value doesn't work.

Are you resetting the textbox value some where in the page_load/init before a button click? — Murali Murugesan
– Murali Murugesan, Commented May 9, 2014 at 14:07
As @Murali says this is almost certainly an issue with setting the text of those textboxs somewhere else in the page lifecycle. I highly recommend reading up on the page lifecycle and where event handlers factor into it. — user61470
– user61470, Commented May 9, 2014 at 14:11
Yeah, I'm setting the text with some information from a database on page_load. I assumed textbox.Text would be automaticly updated when I changed the textbox content. I was hoping there would be an easy way to deal with this, but I guess I'll take a look at page lifecycle. Thanks. — Boxiom
– Boxiom, Commented May 9, 2014 at 14:24

Soner Gönül · Accepted Answer · 2014-05-09 14:12:18Z

2

AddWithValue takes parameter value as a second parameter, not SqlDbType.

You are mixing it with Add method.

cmd.Parameters.Add("@FirstName", SqlDbType.VarChar).Value = txtFirstName.Text;

Also use using statement to dispose your SqlConnection and SqlCommand.

EDIT: Ok, that's not the point as you said (And I can't delete my answer because of 5 answer delete limit). I really doubt that your textbox values change in your page life-cycle. By the way, where did you defined these code? Be sure that your textbox values keep their values since these codes were execute.

edited May 9, 2014 at 14:12

answered May 9, 2014 at 14:06

Soner Gönül

99.1k103 gold badges224 silver badges375 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Murali Murugesan Over a year ago

If you read OP specifically

However, if I change the Parameter values from for example txtFirstName.Text to "Bob", it successfully updates the FirstName column in my table to Bob

. Looks like current code has problem with the text box values

Soner Gönül Over a year ago

@Murali You are right. But I can't delete this answer because I had 5 delete answer limit for today. You can downvote it.

Collectives™ on Stack Overflow

Update table with TextBox values

1 Answer 1

2 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Linked

Related