Problems with console output in C#

Question

I have a litte problem on Console.WriteLine(). I have my while(true) loop that would check the data if exist and it would allow checking the data 3 times. And inside my loop I have this message:

Console.WriteLine(string.format("Checking data {0}",ctr));

Here's my sample code below:

int ctr = 0;

while(true)
{
  ctr += 1;

  Console.WriteLine(string.format("Checking data {0}...",ctr))  

  if(File.Exist(fileName)) 
     break;

  if(ctr > 3)
     break;

}

Let's assume that data was not found.

My current output show like this:

Checking data 1...
Checking data 2...
Checking data 3...

But the correct output that I should want to achieve should looks like this:

Checking data 1...2...3...

I would show only in one line.

Edit:

I forgot: In addition to my problem I want to append "Not Found" and "Found".

Here's the sample Output:

if data found on the First loop output looks like this.

Checking data 1... Found!
if data found on the Second loop output looks like this.

Checking data 1...2...Found!
if data found on the Third loop output looks like this.

Checking data 1...2...3...Found!

AND If data not found

Checking data 1...2...3... Not Found!

Edit your question please. Highlight your code and press the Code Sample button — Brian R. Bondy
– Brian R. Bondy, Commented Feb 25, 2010 at 6:22
As @ItzWarty says, using string.Format is redundant with Console.Write/WriteLine; — Dykam
– Dykam, Commented Feb 25, 2010 at 6:30
while(true) { ... break; ... break; } is absolutely identical in structure, intent, and code quality to 2 conditional gotos and a looping, non-conditional goto. It's spaghetti code, and will have all the problems of spaghetti code when it comes to maintenance, debugging, understandability, and obviousness of correctness. Kurt at least is a beginner, but any experienced coder should have the same apprehension about this control structure pattern as they would for a live grenade thrown into their office. — Wedge
– Wedge, Commented Feb 25, 2010 at 12:40

Brian Rasmussen · Accepted Answer · 2010-02-25 08:57:30Z

8

Use Console.Write instead if you don't want the line break. You also need to move the text out of the loop to avoid repeating it. Something like

Console.WriteLine("Checking data");
int ctr = 0;
bool found = false; 

while (ctr++ < 3 && !found) {
   Console.Write(" {0}...", ctr);
   if (File.Exists(fileName)) found = true;
}
Console.WriteLine(found ? "Found" : "Not found");

edited Feb 25, 2010 at 8:57

answered Feb 25, 2010 at 6:20

Brian Rasmussen

117k34 gold badges226 silver badges325 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Scott Smith Over a year ago

...and output the "Checking data" part outside (above) your loop.

xxx_zzzz Over a year ago

You made it Brian! Exactly that's what i want to achieve. Thank you so much guys. @ Scott, thank you man.

Brian Rasmussen Over a year ago

@kurt: Glad I could help. You should accept one of the answers then.

xxx_zzzz Over a year ago

Hi again guys, I forgot , In addition to my problem I want to append "Not Found" and "Found" Here's the sample Output: 1.if data found on the First loop output looks like this. Checking data 1... Found! 2.if data found on the Second loop output looks like this. Checking data 1...2...Found! 3.if data found on the Third loop output looks like this. Checking data 1...2...3...Found! AND If data not found 4. Checking data 1...2...3... Not Found!

Binary Worrier Over a year ago

-1: Sorry, I can't condone any answer that perpetuates that dreadful while(true)

|

Warty · Accepted Answer · 2010-02-25 06:24:36Z

4

Sidenote:
instead of using Console.WriteLine(string.format("Checking data {0}...",ctr));
you could use Console.WriteLine("Checking data {0}...",ctr); which in my opinion, is easier to read

answered Feb 25, 2010 at 6:24

Warty

7,4141 gold badge34 silver badges53 bronze badges

1 Comment

Ravisha Over a year ago

how is that? Both are same for me except for an extra API call which is an ovehead.Instead the writeln internally does whtt you are inteding to do.i think u r accustomed to string.format which is why u are marketing it:) just kidding

Wedge · Accepted Answer · 2010-02-25 08:36:39Z

1

public static void Main(string[] args)
{
    int retries = 0;
    bool success = false;
    int maxRetries = 3;
    string fileName = args[0];

    Console.Write("Checking data ");

    while(!success && retries++ < maxRetries)
    {
        Console.Write("{0}...", retries);
        success = File.Exists(fileName);
    }
    Console.WriteLine(" {0}Found!", (success ? "" : "Not ") );
}

edited Feb 25, 2010 at 8:36

answered Feb 25, 2010 at 8:31

Wedge

19.9k7 gold badges51 silver badges71 bronze badges

Comments

Peter Mortensen · Accepted Answer · 2010-02-25 11:33:06Z

1

You can output "Checking data" before the while loop. So the code will be like this:

Console.Write("Checking data ")
int ctr = 0;
while(true) {

    ctr += 1;

    Console.Write(string.format("{0}...",ctr))

    if (File.Exist(fileName)) break;

    if (ctr > 3) break;

}

edited Feb 25, 2010 at 11:33

Peter Mortensen

31.4k22 gold badges110 silver badges134 bronze badges

answered Feb 25, 2010 at 6:23

scatman

14.6k23 gold badges72 silver badges94 bronze badges

Comments

Brian · Accepted Answer · 2015-06-01 22:04:01Z

1

A better approach (at least I feel so) with reduced condition check:

public static void Main(string[] args)
{
    int ctr = 0;
    string fileName = args[0];
    string result = "Checking data ";
    do
    {
        ctr += 1;
        result += ctr.ToString() + "...";
    }
    while(!File.Exists(fileName) && ctr <= 3);
    Console.WriteLine(result);
}

edited Jun 1, 2015 at 22:04

Brian

16k7 gold badges38 silver badges43 bronze badges

answered Feb 25, 2010 at 6:38

Ravisha

3,3839 gold badges44 silver badges69 bronze badges

3 Comments

Bernhard Hofmann Over a year ago

If you're going to be appending to a string, you should use a StringBuilder.

Binary Worrier Over a year ago

@Bernhard Hofmann: In this instance? No, a string builder is not necessary. However no upvote either because building the result string here is completely unecessarry.

Bernhard Hofmann Over a year ago

@Binary Worrier: I just don't like examples that don't show the correct way to do things. It's the MS examples without error or exception handling that leads to so much poor production code. Just like to remind people from time to time. :)

Simon Nickerson · Accepted Answer · 2010-02-25 06:21:55Z

0

Use Console.Write() to avoid appending the new line.

To prevent "Checking data" being printed more than once, move it out of the loop.

answered Feb 25, 2010 at 6:21

Simon Nickerson

43.3k21 gold badges107 silver badges127 bronze badges

Comments

Nasser Hadjloo · Accepted Answer · 2010-02-25 06:58:50Z

0

You have to use

Console.Write()

answered Feb 25, 2010 at 6:58

Nasser Hadjloo

12.7k15 gold badges71 silver badges102 bronze badges

Comments

madatanic · Accepted Answer · 2010-02-25 15:51:55Z

-1

Try this code:

 int ctr = 0;
 string result = "Checking data ";
 while(true) {

     ctr += 1;

     result += ctr.ToString() + "...";

     if(File.Exist(fileName))
     {
         result += "Found";
         break;
     }

     if(ctr > 3)
     {
         result += "Not Found";
         break;
     }
 }
 Console.WriteLine(result);

edited Feb 25, 2010 at 15:51

answered Feb 25, 2010 at 6:23

madatanic

1,7903 gold badges16 silver badges29 bronze badges

2 Comments

xxx_zzzz Over a year ago

I tried your code Madatanic and it works! thank you man! Those who contributed to my question thank you so much guys for the quick response... Regards, kurt

madatanic Over a year ago

You're welcome. I have modified my code to fit your request too.

Collectives™ on Stack Overflow

Problems with console output in C#

8 Answers 8

8 Comments

1 Comment

Comments

Comments

3 Comments

Comments

Comments

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

8 Comments

1 Comment

Comments

Comments

3 Comments

Comments

Comments

2 Comments

Related