JavaScript / jQuery why doesn't this work?

Question

function checkSession(){
    $.ajax({url: "session.php", success: function(data){
         if( data == 1){
             var postFilen = 'msg.php';
             $.post(postFilen, function(data){
                 $("#msg").html(data).find("#message2").fadeIn("slow")
            }
         } else {
             $('#message2').hide();
         }
    }});
// setInterval('checkSession()',1000);
}

Basically, this is checking if data is 1 in session.php, and if it is, it should run msg.php´s div #message2 in #msg

What is not working? Any errors?

Felix Kling
– Felix Kling

2010-02-24 21:55:03 +00:00
Commented Feb 24, 2010 at 21:55 — Felix Kling
– Felix Kling, Commented Feb 24, 2010 at 21:55
You are missing ); for $.post(. Is this code correct?

Ivan Nevostruev
– Ivan Nevostruev

2010-02-24 21:57:38 +00:00
Commented Feb 24, 2010 at 21:57 — Ivan Nevostruev
– Ivan Nevostruev, Commented Feb 24, 2010 at 21:57
I dont get any errors.. How "format" my code?

Karem
– Karem

2010-02-24 21:59:11 +00:00
Commented Feb 24, 2010 at 21:59 — Karem
– Karem, Commented Feb 24, 2010 at 21:59

Skilldrick · Accepted Answer · 2010-02-24 22:07:50Z

2

If you formatted your code more logically it would be clearer what your intentions were with this.

In your $.post() call, you close the curly brace on the function, but you don't close the $.post() paren.

Replace:

$.post(postFilen, function(data){
    $("#msg").html(data).find("#message2").fadeIn("slow")
}

with:

$.post(postFilen, function(data){
    $("#msg").html(data).find("#message2").fadeIn("slow");
});

Edit: This is what I mean by properly format:

function checkSession() {
    $.ajax({url: "session.php", success: function(data){
        if(data == 1) {
            var postFilen = 'msg.php';
            $.post(postFilen, function(data){
                $("#msg").html(data).find("#message2").fadeIn("slow");
            });
        } else {
            $('#message2').hide();
        }
    }});
}

edited Feb 24, 2010 at 22:07

answered Feb 24, 2010 at 21:59

Skilldrick

71.1k37 gold badges182 silver badges231 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Skilldrick Over a year ago

Every time you open a new curly brace, you should indent the following code. That way it's obvious that the code is 'inside' the curly braces.

Skilldrick Over a year ago

What editor are you using? Any decent text editor will help you match parens/braces and help you with your indentation as well.

Skilldrick Over a year ago

Another thing to look out for is missing semicolons. Although you can sometimes leave them out, it's always best to use them (e.g. after fadeIn("slow").

Collectives™ on Stack Overflow

JavaScript / jQuery why doesn't this work?

1 Answer 1

3 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Related