jQuery Replace Element Content

Question

I am trying to replace the content of a <td> element when it exactly matches a string. My code does not seem to work, can anyone please say what I might be doing wrong?

<script>
    $(document).ready(function(){
        $("td").click(function(){
            if (Matches(this, "1")
                ReplaceCellContent(this,"A");
        });
    });

    <!-- Replaces an HTML inner value [find] with a new value [replace] -->
    function ReplaceCellContent(element, replace) {
        $(.element).html(replace);
    }

    <!-- Returns true if [element] contains [stringToMatch] -->
    function Matches(element, stringToMatch) {
        return $(element).text() === stringToMatch;
    }
</script>

Hopefully you didn't use HTML comments in javascript? And you have syntax errors, open the console. — adeneo
– adeneo, Commented Mar 21, 2014 at 12:51
Yes, I did.. I have changed the comments to javascript style and the console prints Unexpected identifier with line 5, which calls the ReplaceCellContent function. Unfortunately I can't see what is wrong with it. — codefi
– codefi, Commented Mar 21, 2014 at 14:29
You're missing a closing parenthesis, and there are more syntax errors. — adeneo
– adeneo, Commented Mar 21, 2014 at 14:32
Thanks I had difficulty spotting that, I am used to using Eclipse but have started using Notepad++ for Javascript. Is there perhaps an IDE for JavaScript that will show syntax errors that you can recommend? — codefi
– codefi, Commented Mar 21, 2014 at 14:39
@Adamme You might wanna look at Sublime for web development. Plugin developed by users are very helpful. — Karl-André Gagnon
– Karl-André Gagnon, Commented Mar 21, 2014 at 14:59

Karl-André Gagnon · Accepted Answer · 2014-03-21 14:38:57Z

1

The problem is that $(element).text() return the text including new line character and tabulation.

Try to trim that value :

return $.trim($(element).text()) === stringToMatch;

You are missing a closing parenthesis :

if (Matches(this, "1"))

edited Mar 21, 2014 at 14:38

answered Mar 21, 2014 at 12:51

Karl-André Gagnon

33.9k5 gold badges53 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

codefi Over a year ago

I tried the trim function but it doesn't make a difference. The error is with the ReplaceCellContent function, but I am not sure what why.

Karl-André Gagnon Over a year ago

Yeah, a missing parenthesis.

Collectives™ on Stack Overflow

jQuery Replace Element Content

1 Answer 1

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Related