Bash: Syntax error near unexpected token `then'

Question

the error is at line 21...

if [ $weight1 -gt $weight2 ];
    then echo "Weight 2 should be greater than Weight 1."
else
    if [ $weight1 -ge 20 ] && [ $weight1 -le 39 ];
        then echo "Weight 1 is bike."
    else 
        echo "Weight 1 is either bicycle, car, van or lorry."
    fi
fi

The code, as posted, works for me. Please post the code that fails. — John1024
– John1024, Commented Feb 10, 2014 at 7:39
we don't know where the problem is? and where the line 21 is? — MLSC
– MLSC, Commented Feb 10, 2014 at 7:54

Малъ Скрылевъ · Accepted Answer · 2014-02-10 07:45:17Z

I done\'t see the issue, on my tests then keyword is worked for your case, anyway some noted on your code:

Put then on the line of if operator:

if [ $weight1 -ge 20 ] && [ $weight1 -le 39 ]; then

Enclose your variables into quotes:

if [ "$weight1" -ge 20 ] && [ "$weight1" -le 39 ]; then

I recommend to use -a key, instead to two calls to [ app:

if [ "$weight1" -ge 20 -a "$weight1" -le 39 ]; then

NOTE: The error Syntax error near unexpected token 'then' can rise up mostly in a few cases:

When you specify then keyword outside of if case:

weight1=21
    then echo "Weight 1 is bike."
else
    echo "Weight 1 is either bicycle, car, van or lorry."
fi

when youve specified then twice:

if [ "$weight1" -ge 20 -a "$weight1" -le 39 ]; then
then echo "Weight 1 is bike."

when you've put then to improper place, for example, after the else operator:
```
else
then
    echo "Weight 1 is either bicycle, car, van or lorry."
fi
```

MLSC · Accepted Answer · 2014-02-10 07:50:38Z

0

just

chmod +x test.sh

first line: add #!/bin/bash

then do:

./test.sh

It is working whithout problem

answered Feb 10, 2014 at 7:50

MLSC

5,9728 gold badges60 silver badges90 bronze badges

Collectives™ on Stack Overflow

Bash: Syntax error near unexpected token `then'

2 Answers 2

1 Comment

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Related