iOS: Reload table view not working

Question

I'm displaying twitter feed in a UITableView. It loads properly. I've added a Bar button item (refresh) to refresh the table. However, clicking it doesn't reload the table. The onClick function is called but the code in it isn't executed.

//"TwitterViewController.h"
#import "ViewController.h"

@interface TwitterViewController : UITableViewController
- (IBAction)refresh:(id)sender;

@end

Here is a part of my "TwitterViewController.m"

- (void)viewDidLoad
{
    [super viewDidLoad];
    [self loadTweets];
}


- (void)loadTweets
{

    STTwitterAPI *twitter = [STTwitterAPI twitterAPIAppOnlyWithConsumerKey:@"consumer key"
                                                            consumerSecret:@"consumer secret"];
    [twitter verifyCredentialsWithSuccessBlock:^(NSString *bearerToken) {

        [twitter getUserTimelineWithScreenName:@"username"
                                  successBlock:^(NSArray *statuses) {

                                      self.twitterFeed = [NSMutableArray arrayWithArray:statuses];

                                      [self.tableView reloadData];

                                  } errorBlock:^(NSError *error) {

                                      NSLog(@"%@", error.debugDescription);

                                  }];

    } errorBlock:^(NSError *error) {
        NSLog(@"%@", @"Error");

    }];
}



- (IBAction)refresh:(id)sender {
    [self.tableView reloadData];
}

reloadData on a UITableView doesn't call viewDidLoad again. You need to study the UITableViewDelegate and UITableViewDataSource protocols to better understand the reloadData method. — Luke
– Luke, Commented Feb 5, 2014 at 16:51

Alban · Accepted Answer · 2014-02-05 16:54:34Z

3

You need to re affect the value in twitterFeed array before to reload the tableview, otherwise data will be the same.

Simply call:

[self loadTweets];

instead of

[self.tableView reloadData];

so:

- (IBAction)refresh:(id)sender {
    [self loadTweets];
}

answered Feb 5, 2014 at 16:54

Alban

1,62211 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Bilbo Baggins Over a year ago

Hi Alban, I did try that as well. However the function gets called but there is no change.

Mika · Accepted Answer · 2014-02-05 17:22:12Z

1

Try this it will be more elegant than reload data.

- (IBAction)refresh:(id)sender {
     [self loadTweets];
}

In loadTweets:

    successBlock:^(NSArray *statuses) {
                                 [self.tableView beginUpdates];

                                  self.twitterFeed = [NSMutableArray arrayWithArray:statuses];

                                  [self.tableView endUpdates];
 }

edited Feb 5, 2014 at 17:22

answered Feb 5, 2014 at 16:57

Mika

5,8556 gold badges40 silver badges84 bronze badges

6 Comments

WDUK Over a year ago

For beginUpdates, the docs say: "You should not call reloadData within the group". loadTweets calls reloadData, so this isn't the way to go.

Mika Over a year ago

Yes you are correct sorry I had not gone through loadTweets. I will ammend my response.

Bilbo Baggins Over a year ago

Are you sure that the successBlock won't contain [self.tableView reloadData];? I tried your code but now the table doesn't load at all. The spinner keeps spinning.

Mika Over a year ago

Sorry I made a mistake. Should be beginUpdates and endUpdates. Don't need reloadData.

Bilbo Baggins Over a year ago

Hi Mikael, the app crashed with the following error - 'NSInternalInconsistencyException', reason: 'Invalid update: invalid number of rows in section 0. The number of rows contained in an existing section after the update (20) must be equal to the number of rows contained in that section before the update (0), plus or minus the number of rows inserted or deleted from that section (0 inserted, 0 deleted) and plus or minus the number of rows moved into or out of that section (0 moved in, 0 moved out).

|

user3276236 · Accepted Answer · 2014-02-05 17:35:45Z

Try this:

//"TwitterViewController.h"
#import "ViewController.h"

@interface TwitterViewController : UITableViewController
@property (strong, nonatomic) STTwitterAPI *twitter;
- (IBAction)refresh:(id)sender;

@end

TwitterViewController.m

- (void)loadTweets
{

    if (!self.twitter) {
      self.twitter = [STTwitterAPI twitterAPIAppOnlyWithConsumerKey:@"consumer key"
                                                            consumerSecret:@"consumer secret"];
    }
    __weak typeof(self) weakSelf = self;
    [self.twitter verifyCredentialsWithSuccessBlock:^(NSString *bearerToken) {

    [weakSelf.twitter getUserTimelineWithScreenName:@"username"
                                  successBlock:^(NSArray *statuses) {

                                      weakSelf.twitterFeed = [NSMutableArray arrayWithArray:statuses];

                                      [weakSelf.tableView reloadData];

                                  } errorBlock:^(NSError *error) {

                                      NSLog(@"%@", error.debugDescription);

                                  }];

    } errorBlock:^(NSError *error) {
        NSLog(@"%@", @"Error");

    }];
}

object 'STTwitterAPI' is removed before completion of the request

Collectives™ on Stack Overflow

iOS: Reload table view not working

3 Answers 3

1 Comment

6 Comments

2 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

6 Comments

2 Comments

Linked

Related