Trouble with R function

Question

I try to create a function. But when I change the sequence of it then it create NA values out. Any particular reason to it? Thanks

new<-function(x){
    min2<-NULL
    min1<-NULL
    len<-length(unique(x))
for (i in 1:(len-1)) 
    min2[i]<-sort(x,partial=(len-i+1))[(len-i+1)]
    min1[i]<-sort(x,partial=(len-i))  [(len-i)]
    return((min1))  
}


x<-c(1,11,40,120)

new(x)

[1] 120  40  11




new<-function(x){
    min2<-NULL
    min1<-NULL
    len<-length(unique(x))
for (i in 1:(len-1)) 
    min1[i]<-sort(x,partial=(len-i))  [(len-i)]
    min2[i]<-sort(x,partial=(len-i+1))[(len-i+1)]
    return((min1))  
}


x<-c(1,11,40,120)

new(x)

[1] NA  NA  11

Roland · Accepted Answer · 2014-01-27 09:28:06Z

3

You forgot curly parentheses around the expression you want to repeat in you for loop:

new<-function(x){
    min2<-NULL
    min1<-NULL
    len<-length(unique(x))
    for (i in 1:(len-1)) {
      min2[i]<-sort(x,partial=(len-i+1))[(len-i+1)]
      min1[i]<-sort(x,partial=(len-i))  [(len-i)] 
    }
    return(min1)  
}

answered Jan 27, 2014 at 9:28

Roland

134k12 gold badges203 silver badges305 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

chee.work.stuff Over a year ago

Thanks. Thats very silly of me to forget about the parentheses.

Collectives™ on Stack Overflow

Trouble with R function

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related