Angular: update scope with async AJAX data from a factory

Question

What's the recommended way to do this?

1.

factory.updater = function(varObjToBeUpdated){
    $http.post('/url', {})
    .success(function(data){
        for (data_field in data)
            varObjToBeUpdated[data_field] = data[data_field];
    });
} 

...

myFactory.updater($scope.varObjToBeUpdated);

Or 2.,

 myFactory.updater().success(function(data, ..){
    $scope.varObjToBeUpdated = data;
});

...

factory.updater = function(){
    return $http.post('/url', {});
}

Is it ok to to pass a reference scope variable to a factory? I always thought factories as delivering data.

And what's wrong with the second method (if it's less acceptable)?

What's wrong with what you have?

Explosion Pills
– Explosion Pills

2013-12-18 01:15:26 +00:00
Commented Dec 18, 2013 at 1:15 — Explosion Pills
– Explosion Pills, Commented Dec 18, 2013 at 1:15
Sorry, I think the question is more clear now.

xcorat
– xcorat

2013-12-18 01:23:28 +00:00
Commented Dec 18, 2013 at 1:23 — xcorat
– xcorat, Commented Dec 18, 2013 at 1:23

tymeJV · Accepted Answer · 2013-12-18 01:28:18Z

3

I prefer the second approach, as this allows you to just inject the service when you need it across multiple controllers. Use .then to continue the promise pattern:

myFactory.updater().then(function(data, ..){
    $scope.varObjToBeUpdated = data;
});

app.factory('myFactor', function($http) {
    return {
        updater: function() {
            return $http({'/url',}).then(function(result) {
                return result.data;
            });
        }
    }
});

answered Dec 18, 2013 at 1:28

tymeJV

105k14 gold badges165 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Angular: update scope with async AJAX data from a factory

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related