PHP MySQL issue with INSERT INTO

Question

$SQL="INSERT INTO first_name VALUES (fname) SELECT first_name FROM people WHERE fname = '$fname'";

I'm trying to insert the value 'fname' which is $fname (variable defined by a user) into the column 'first_name'

It's not adding anything but not displaying any errors. Syntax problem?

mysql_error is the function for returning errors in your query. If I have to read one more post about this I am going to scream. — Tim Seguine
– Tim Seguine, Commented Dec 17, 2013 at 21:57
As another aside, it's highly unsafe to just stick that ol' $fname into the query. Since you're using it, I'm assuming that you're using the mysql_* family of functions, which is BAD. The question that I just linked also has resources on alternatives. — Chris Forrence
– Chris Forrence, Commented Dec 17, 2013 at 22:01

John Woo · Accepted Answer · 2013-12-17 21:57:32Z

2

you don't need VALUES() here

INSERT INTO first_name
SELECT first_name 
FROM people WHERE fname = '$fname'

answered Dec 17, 2013 at 21:57

John Woo

265k70 gold badges507 silver badges500 bronze badges

Sign up to request clarification or add additional context in comments.

1 Answer 1