Pass ArrayList to another Class

Question

I'm having some Trouble with an ArrayList. All i need to do is to pass a filled ArrayList to another Class so i can use the Values of the ArrayList there. Here's a snippet from the first Class:

public ArrayList<String> collCollect = new ArrayList<String>();
for (int i = 0; i < ListModel.size(); i++) {
        collCollect.add(ListModel.get(i).toString());
    }
    System.out.println(collCollect);

Till this Part everything is going quite well (i stripped the rest of the Code!)

Now comes the tricky Part! This is the Second Class:

ClassA pMain;
DecimalFormat f = new DecimalFormat("#0.00");
public ArrayList<String> listContent = new ArrayList<String>(pMain.collCollect);
DefaultListModel<String> ListModelNew = new DefaultListModel<String>();

public static void main(String args[]) {
for (int i = 0; i < listContent.size(); i++){
        ListModelNew.add(i, listContent.get(i));
    } 
}

Everytime the ClassB is loaded i get a NullPointerException from the Line where the reference to the Array in pMain is made.

Any help would be appriciated...i'm unable to get the Values from ClassA ArrayList to ClassB -.-

You need to initialize pMain. ClassA pMail = new ClassA(); — MAV
– MAV, Commented Nov 25, 2013 at 12:37

Prabhakaran Ramaswamy · Accepted Answer · 2013-11-25 12:38:10Z

3

ClassA pMain; // here you not initialized the object.

pMain.collCollect // here you are getting the NullpointerException

public ArrayList<String> listContent = new ArrayList<String>(pMain.collCollect);
                                                                    ^__see here

change

ClassA pMain;

to

ClassA pMain = new ClassA ();

answered Nov 25, 2013 at 12:38

Prabhakaran Ramaswamy

26.1k10 gold badges61 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kevin Bowersox · Accepted Answer · 2013-11-25 12:38:12Z

An instance of ClassA needs to be created in the second class. I would recommend creating it within the main method so ClassA is not a dependency for the second class.

DecimalFormat f = new DecimalFormat("#0.00");
public ArrayList<String> listContent; 
DefaultListModel<String> ListModelNew = new DefaultListModel<String>();

public static void main(String args[]) {
ClassA pMain = new ClassA();
listContent = new ArrayList<String>(pMain.collCollect);
for (int i = 0; i < listContent.size(); i++){
        ListModelNew.add(i, listContent.get(i));
    } 
}

This can be further refactored:

DecimalFormat f = new DecimalFormat("#0.00");
DefaultListModel<String> ListModelNew = new DefaultListModel<String>();

public static void main(String args[]) {
ClassA pMain = new ClassA();
for (int i = 0; i < pMain.collCollect.size(); i++){
        ListModelNew.add(i, pMain.collCollect.get(i));
    } 
}

I forgot to initialize the ClassA -.- Ok but now nothing is added to the ListModelNew?!?! The StandardOutPrint shows me "[]"?!? I'm getting more and more confused

ioreskovic · Accepted Answer · 2013-11-25 12:44:21Z

1

Your ClassA pMain is not instantiated. You need to create the actual instance of ClassA like this:

ClassA pMain = new ClassA();

Since you're trying to get a public property of that class (collCollect), it would be sane to have that one exist too, either via constructor in ClassA or by calling some method on the newly created instance of ClassA.

answered Nov 25, 2013 at 12:44

ioreskovic

5,7377 gold badges41 silver badges71 bronze badges

Comments

Michael Rose · Accepted Answer · 2013-11-25 12:38:22Z

0

Well you just declare the variable pMain but never assign it anything. Thus it will be initialized with null and give you a NullPointerException when you try to access it.

You must either declare it like ClassA pMain = new ClassA() or assign a value elsewhere. If you assign the value elsewhere be sure to remove the direct initialization of listContent

answered Nov 25, 2013 at 12:38

Michael Rose

7,8203 gold badges24 silver badges27 bronze badges

Comments

Matt · Accepted Answer · 2013-11-25 12:44:37Z

0

Instead of having the instantiator at the top of your class:

public ArrayList<String> listContent = new ArrayList<String>(pMain.collCollect);

Override the constructor for your second class, and pass it in there:

public ClassB(ArrayList<String> pMain) {
  this.listContent = pMain.collCollect;
}

answered Nov 25, 2013 at 12:44

Matt

3,3736 gold badges34 silver badges55 bronze badges

Comments

Kishore · Accepted Answer · 2013-11-25 12:58:03Z

0

@Ben, You can keep array initialization code in collCollectInit() of ClassA. In second class create ClassA object as ClassA pMain=new ClassA(); pMain.collCollectInit(); then use pMain.collCollect if collCollect is a public or protected reference in ClassA. Please use getter and setter method to access class variable.

answered Nov 25, 2013 at 12:58

Kishore

3003 silver badges14 bronze badges

Comments

ZeroGS · Accepted Answer · 2013-11-25 13:04:42Z

0

Ok i must have been blind not to initialize the ClassA in ClassB...that is fixed now. But the ListModelNew doesn't have any content it is out printed as "[]" so i think the ArrayList in ClassA is not passing the Values properly to ArrayList listContent in ClassB

answered Nov 25, 2013 at 13:04

ZeroGS

1392 gold badges3 silver badges11 bronze badges

Collectives™ on Stack Overflow

Pass ArrayList to another Class

7 Answers 7

Comments

1 Comment

Comments

Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

1 Comment

Comments

Comments

Comments

Comments

Comments

Related