Using a variable as a column name in rails

Question

I'm trying to set up two environments for my site, one on a development server, one on a live one. And I want to dictate which records from the DB can be seen on each server. I've created a file in my includes, for development it has this @show = "dev" and for live it has @show = "live" I've included this at the top of my application layout so it is on every page. Then in my views, with each database call I want to put some conditions like this:

- f = Event.find(:all, :conditions => ["#{@show} = 1"])

But it doesn't pick up @show as being the variable, just uses it explicitly or ignores it. Is there a simple way to do this or will this not work how I expect it to?

update

I've managed to make it work, but I have to include the file on each individual view rather than just on the application layout... Not ideal but it's a solution:

= render "includes/dev_live"

- f = Event.find(:all, :conditions => {@show => 1})

what is preventing you from having separate databases for each environment? — Ian Kenney
– Ian Kenney, Commented Jul 15, 2013 at 8:58
I don't want to have two copies of everything, that's how it was before and everything was out of sync — user1738017
– user1738017, Commented Jul 15, 2013 at 8:59
Using text substitution inside a query is kinda frowned upon, due to the possibility of SQL injection. I suspect it is unlikely that the value of @show can be changed by a malicious user, it is good practice to use the hash form for conditions (as in the two answers below) — Slicedpan
– Slicedpan, Commented Jul 15, 2013 at 9:26
I would suggest using the built-in rails environment accessor (Rails.env) rather than your own global variable. — DaveMongoose
– DaveMongoose, Commented Jul 15, 2013 at 9:27
Why would you need up-to-date data on development? And what is stopping you from dumping production db everyday into development? — Mike Szyndel
– Mike Szyndel, Commented Jul 15, 2013 at 14:11

Slicedpan · Accepted Answer · 2013-07-15 09:21:34Z

1

I think you would be better off changing your variables to symbols i.e

@show = :dev
@show = :live

then your active record query could become:

f = Event.find(:all, :conditions => {@show => 1})

answered Jul 15, 2013 at 9:21

Slicedpan

5,0172 gold badges20 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Amitkumar Jha · Accepted Answer · 2013-07-15 09:17:44Z

0

you need to convert a Variable into instance variable. for using it in conditions.

You can try this

f = Event.find(:all, :conditions => {@show.to_sym => 1 })

answered Jul 15, 2013 at 9:17

Amitkumar Jha

1,3531 gold badge11 silver badges15 bronze badges

Collectives™ on Stack Overflow

Using a variable as a column name in rails

2 Answers 2

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Related