Updating an element in array

Question

I'm using Angularjs. I a have table where users can add and update a user list. When someone edits an existing user I'm first removing that user from a scoped array then pushing the updated object.

$.each($scope.users, function (index, value) {
  if (value['empId'] == $scope.userToAdd.empId) {
    console.log(index);
    $scope.users.splice(index, 1);
  }
});
$scope.users.push($scope.userToAdd);

Is this the best way to approach this problem? Second issue I'm having is on the line where I splice. Angular is throwing an error that reads:

Error: value is undefined

The element is still removed but this error prevents the push from happening. I have a feeling this has something to do with scope, but can find the answer. Thanks!

Instead of putting $scope.users.push($scope.userToAdd); at the last put this code after $scope.users.splice(index, 1); it will solve the problem. — Gyanendra
– Gyanendra, Commented Jul 11, 2013 at 10:56
u can also use ng-grid directly out of the box check this -> angular-ui.github.io/ng-grid scroll down to Edit On Focus Cell Selection Example, plnkr-> plnkr.co/edit/KJmYbO?p=preview — Abhishek Nandi
– Abhishek Nandi, Commented Jul 11, 2013 at 11:02
modified ng-grid to suit your need. plnkr.co/edit/cJHgKI?p=preview — Abhishek Nandi
– Abhishek Nandi, Commented Jul 11, 2013 at 11:10

transilvlad · Accepted Answer · 2013-07-11 12:09:46Z

1

The problem with your code is that you are removing from the array while you are iterating over it, which is inconsistent.

What you should do is

Find the index of the user you want to delete (Using some looping construct like $.each)
Splice the element out (outside the loop).
Add it back.

Something like

$.each($scope.users, function (index, value) {
    if (value['empId'] == $scope.userToAdd.empId) {
        userFoundAt=index;
    }
});
$scope.users.splice(userFoundAt, 1);
$scope.users.push($scope.userToAdd);

edited Jul 11, 2013 at 12:09

transilvlad

14.6k13 gold badges48 silver badges81 bronze badges

answered Jul 11, 2013 at 11:00

Chandermani

42.7k12 gold badges87 silver badges89 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Updating an element in array

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related