Null pointer exception with imageView

Question

Null pointer exception on 'giraffe.getX()' and not sure why, i must be declaring something wrong? Below is the code the xml and the stack trace the error is on line 36 dx = x- giraffe.getX()

public class MainGameActivity extends Activity implements OnTouchListener {

float x,y,dx,dy;
ImageView giraffe;
private static final String ONTOUCH_TAG = "Entered onTouch()";


@Override
protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        this.requestWindowFeature(Window.FEATURE_NO_TITLE);
        setContentView(R.layout.activity_main_game);
        ImageView giraffe = (ImageView)findViewById(R.id.giraffe);
        giraffe.setOnTouchListener(this);
}


public boolean onTouch(View v, MotionEvent me){

    if(me.getAction() == MotionEvent.ACTION_DOWN){
        Log.d(ONTOUCH_TAG, "ONTOUCH");
        x = me.getX();
        y = me.getY();
        dx = x - giraffe.getX();
        dy = y - giraffe.getY();
    }

    if(me.getAction() == MotionEvent.ACTION_MOVE)
    {
        giraffe.setX(me.getX()-dx);
        giraffe.setY(me.getY()-dy);
    }

    return true;
}

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    // Inflate the menu; this adds items to the action bar if it is present.
    getMenuInflater().inflate(R.menu.activity_main_game, menu);
    return true;
}

}

Layout file:

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
tools:context=".MainGameActivity" >

<ImageView
    android:id="@+id/giraffe"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_alignParentBottom="true"
    android:layout_centerHorizontal="true"
    android:layout_marginBottom="58dp"
    android:contentDescription="@string/giraffe"
    android:src="@drawable/giraffeicon" />

</RelativeLayout>

Stack trace

07-07 14:47:49.606: E/AndroidRuntime(1229): FATAL EXCEPTION: main
07-07 14:47:49.606: E/AndroidRuntime(1229): java.lang.NullPointerException
07-07 14:47:49.606: E/AndroidRuntime(1229):     at com.SandBProductions.fallingobjects.MainGameActivity.onTouch(MainGameActivity.java:36)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.View.dispatchTouchEvent(View.java:7234)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2174)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1875)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2174)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1875)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2174)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1875)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2174)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1875)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:1953)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at com.android.internal.policy.impl.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1405)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.app.Activity.dispatchTouchEvent(Activity.java:2410)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:1901)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.View.dispatchPointerEvent(View.java:7419)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewRootImpl.deliverPointerEvent(ViewRootImpl.java:3220)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:3165)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:4292)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:4271)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:4363)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:179)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.os.MessageQueue.nativePollOnce(Native Method)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.os.MessageQueue.next(MessageQueue.java:125)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.os.Looper.loop(Looper.java:124)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at android.app.ActivityThread.main(ActivityThread.java:5039)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at java.lang.reflect.Method.invokeNative(Native Method)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at java.lang.reflect.Method.invoke(Method.java:511)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:793)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:560)
07-07 14:47:49.606: E/AndroidRuntime(1229):     at dalvik.system.NativeStart.main(Native Method)

user1888162 · Accepted Answer · 2013-07-07 14:56:50Z

3

ImageView giraffe is null:

ImageView giraffe;



@Override
protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        giraffe = (ImageView)findViewById(R.id.giraffe);

}

answered Jul 7, 2013 at 14:56

user1888162

1,74521 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Brian Over a year ago

thank you very much...staring way too long at such a simple fix -_-

IanB · Accepted Answer · 2013-07-07 14:57:20Z

3

You have defined giraffe twice (once globally and once in onCreate):

ImageView giraffe = (ImageView)findViewById(R.id.giraffe);

remove ImageView from this statement and it will work.

answered Jul 7, 2013 at 14:57

IanB

3,4891 gold badge22 silver badges24 bronze badges

Collectives™ on Stack Overflow

Null pointer exception with imageView

2 Answers 2

1 Comment

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Related