use array item as selector object

Question

i'm messing around with arrays and have a very basic question. lets say i have this html-markup:

<div id="1" style="width: 50px; height: 50px; background-color: #ff0; display: none;"></div>
<div id="2" style="width: 50px; height: 50px; background-color: #ffc; display: none;"></div>
<div id="3" style="width: 50px; height: 50px; background-color: #fcc; display: none;"></div>

and create the following array:

var testArr = ['$("#1")', '$("#2")', '$("#3")'];

why i cant execute the following function to work:

 function showArr() { testArr[2].show(); 
  };
 showArr();

therefore shouldn't #3 get displayed?

thanks

This generally isn't the way to do this. You select all the elements like var elems = $('#1, #2, #3') and then based on the order in the DOM you select what to show, like elems.eq(2).show(), you don't stick elements in an array unless you have a really good reason to do so, and this doesn't look like it is such a reason. And you shouldn't use just a number for ID's. — adeneo
– adeneo, Commented Jun 11, 2013 at 22:41
yea, but i only made that for understanding arrays. its not like i want to store selector into arrays. its just that i was trying out, and understand how they work! — supersize
– supersize, Commented Jun 11, 2013 at 22:46
If you stored just the ids in the array, you could use the (fairly-horrible) approach here: (horrible) demo (don't seriously consider using this). — David Thomas
– David Thomas, Commented Jun 11, 2013 at 22:55

David Thomas · Accepted Answer · 2013-06-11 22:49:09Z

3

No. This won't work because you're attempting to run a function on a string.

testArr[2] is '$("#3")'. Not a jQuery object: it is a string that contains code. So testArr[2].show() means '$("#3")'.show(). Since strings don't have a show method, this won't work.

You need to store jQuery objects, not strings:

var testArr = [$("#1"), $("#2"), $("#3")];

edited Jun 11, 2013 at 22:49

David Thomas

254k53 gold badges382 silver badges421 bronze badges

answered Jun 11, 2013 at 22:37

lonesomeday

239k54 gold badges330 silver badges329 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

supersize Over a year ago

thanks for explanation, i'm learning and people like you help me alot! works fine!

Shaddow Over a year ago

or you can store selectors in array - var testArr = ["#1", "#2", "#3"]; and then use in jQuery object - $(testArr[2]).show();

meder omuraliev · Accepted Answer · 2013-06-11 22:35:51Z

1

First off, ids can't start with numbers. Secondly, dont store it as a string, just store the object.

testArr = [ $('#item-1'), $('#item-2') ];

answered Jun 11, 2013 at 22:35

meder omuraliev

187k76 gold badges401 silver badges443 bronze badges

4 Comments

David Thomas Over a year ago

Under HTML5 they can (but they're an absolute nuisance to select in CSS if they do...).

supersize Over a year ago

why shouldn't i use numbers as id? Worked always fine for me!

David Thomas Over a year ago

@supersize: try using CSS to style #1, and then tell me it works 'fine.'

supersize Over a year ago

works pretty good! just kidding, you got me, thanks for the hint... ive never realised this!

Collectives™ on Stack Overflow

use array item as selector object

2 Answers 2

2 Comments

4 Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

4 Comments

Related