276

I have initialized several variables in the global scope in a JavaScript file:

var moveUp, moveDown, moveLeft, moveRight;
var mouseDown, touchDown;

I need to set all of these variables to false. This is the code I currently have:

moveUp    = false;
moveDown  = false;
moveLeft  = false;
moveRight = false;
mouseDown = false;
touchDown = false;

Is there any way I can set all of these variables to the same value in one line of code? Or is the code I currently have the best way to do this?

4
  • 25
    All readers: please view second answer below before you decided to implement the top answer into your code. Peace. Commented Aug 14, 2017 at 2:39
  • Don't try to do this, because in memory will be only one variable and the others will be a copy or reference for that one, then if you change the value from one all will be impacted Commented Feb 26, 2019 at 19:36
  • @LucasMatos Not for primitives. Commented Apr 18, 2020 at 2:47
  • i know it's not the answer, but i would use ONE variable "direction" and instead of setting a variable to false, i use the triple = to compare it to true if(moveLeft === true), that way you don't need to set the initial value at all Commented Oct 15, 2020 at 19:15

9 Answers 9

406

Nothing stops you from doing

moveUp = moveDown = moveLeft = moveRight = mouseDown = touchDown = false;

Check this example

var a, b, c;
a = b = c = 10;
console.log(a + b + c)

Sign up to request clarification or add additional context in comments.

10 Comments

You may want to comment how the behavior will differ primitive types and reference types when assigning values the way you suggest.
Yeah, if doing this with an object, all the variables will be aliases of the object. I.E function MyObj(){this.x=1} var a,b; a = b = new MyObj(); ++a.x will also increment the b.x property.
I would say do not use this approach if you are not globally scoping all the variables to the left of the assignment
As @doublejosh said, there are scoping problems you didn't address.
|
189

Nothing stops you from doing the above, but hold up!

There are some gotchas. Assignment in Javascript is from right to left so when you write:

var moveUp = moveDown = moveLeft = moveRight = mouseDown = touchDown = false;

it effectively translates to:

var moveUp = (moveDown = (moveLeft = (moveRight = (mouseDown = (touchDown = false)))));

which effectively translates to:

var moveUp = (window.moveDown = (window.moveLeft = (window.moveRight = (window.mouseDown = (window.touchDown = false)))));

Inadvertently, you just created 5 global variables--something I'm pretty sure you didn't want to do.

Note: My above example assumes you are running your code in the browser, hence window. If you were to be in a different environment these variables would attach to whatever the global context happens to be for that environment (i.e., in Node.js, it would attach to global which is the global context for that environment).

Now you could first declare all your variables and then assign them to the same value and you could avoid the problem.

var moveUp, moveDown, moveLeft, moveRight, mouseDown, touchDown;
moveUp = moveDown = moveLeft = moveRight = mouseDown = touchDown = false;

Long story short, both ways would work just fine, but the first way could potentially introduce some pernicious bugs in your code. Don't commit the sin of littering the global namespace with local variables if not absolutely necessary.


Sidenote: As pointed out in the comments (and this is not just in the case of this question), if the copied value in question was not a primitive value but instead an object, you better know about copy by value vs copy by reference. Whenever assigning objects, the reference to the object is copied instead of the actual object. All variables will still point to the same object so any change in one variable will be reflected in the other variables and will cause you a major headache if your intention was to copy the object values and not the reference.

7 Comments

what if we do this same with let ?
Besides moveUp becoming block-scoped, it would make no difference. 5 global variables would still be declared.
@GovindRai var a, b, c; a = b = c = 10; is very different from var a = b = c = 10;. So, the accepted answer is correct. You are addressing a problem not related to the accepted answer.
@ElisByberi Thanks for your comment. You're not wrong. The goal of my answer was to address the first sentence in the accepted answer. I have provided further clarity in my answer in regards to that.
@P-RAD Only the first variable declared using let will exist in the enclosing scope.
|
25

There is another option that does not introduce global gotchas when trying to initialize multiple variables to the same value. Whether or not it is preferable to the long way is a judgement call. It will likely be slower and may or may not be more readable. In your specific case, I think that the long way is probably more readable and maintainable as well as being faster.

The other way utilizes Destructuring assignment.

let [moveUp, moveDown,
     moveLeft, moveRight,
     mouseDown, touchDown] = Array(6).fill(false);

console.log(JSON.stringify({
    moveUp, moveDown,
    moveLeft, moveRight,
    mouseDown, touchDown
}, null, '  '));

// NOTE: If you want to do this with objects, you would be safer doing this
let [obj1, obj2, obj3] = Array(3).fill(null).map(() => ({}));
console.log(JSON.stringify({
    obj1, obj2, obj3
}, null, '  '));
// So that each array element is a unique object

// Or another cool trick would be to use an infinite generator
let [a, b, c, d] = (function*() { while (true) yield {x: 0, y: 0} })();
console.log(JSON.stringify({
    a, b, c, d
}, null, '  '));

// Or generic fixed generator function
function* nTimes(n, f) {
    for(let i = 0; i < n; i++) {
        yield f();
    }
}
let [p1, p2, p3] = [...nTimes(3, () => ({ x: 0, y: 0 }))];
console.log(JSON.stringify({
    p1, p2, p3
}, null, '  '));

This allows you to initialize a set of var, let, or const variables to the same value on a single line all with the same expected scope.

References:

15 Comments

Beware, however. If assigning Objects, functions, or arrays to multiple variables using this method, each variable will be an alias to the same object. Modifications to one will affect the others...
creating an array to assign a value, please don't
@MartijnScheffer why? If the JavaScript engine compiling the code actually creates and discards an extra array than it would have from compiling a series of direct assignments, it would be implementation specific and fixable.
Yes, once the code is compiled the array is still created, making this method a LOT slower than simply assigning the values. That’s not fixable, don’t allocate memory if u don’t have to. Just do a simple test, write a loot with both versions of the code.
""Write idiomatic JavaScript, and let us worry about the low level bits of the JavaScript performance instead"" -- Benedikt Meurer, V8 performance expert.
|
11

The original variables you listed can be declared and assigned to the same value in a short line of code using destructuring assignment. The keywords let, const, and var can all be used for this type of assignment.

let [moveUp, moveDown, moveLeft, moveRight, mouseDown, touchDown] = Array(6).fill(false);

2 Comments

nice, but it's still totally wrong to allocate memory just to do an assignment.
Using array destructuring is a nice approach. You can also declare an array and explicitly put your values there, being them all equal or all different. let [moveUp, moveDown, moveLeft, ..., touchDown] = [1, False,..., True]
4

I personally try to avoid var at all times, and use let and const always, I learned it from bugs that occur and most best practices recommendations, so below is mentioned in comments but to be more precise:

function good() {  
    let a;
    let b;
    let c;
    let d;        
    a = b = c = d = 'hello';    
    console.log(d);    
}

function bad() {
    //only the first variable is declared as local
    let a = b = c = d = 'bye';
    console.log(d)
}

let a;
let d;

good();
bad();

//expected undefined
console.log(a);

//expected bye 
console.log(d);

Comments

2

If you are determined to declare and initialize the variables all to one value, you can use variable deconstruction with a new array as follows:

let [moveUp, moveDown, moveLeft, moveRight, mouseDown, touchDown] = new Array(6).fill(false);

console.log(moveUp, moveDown, moveLeft, moveRight, mouseDown, touchDown);
// false false false false false false

FWIIW.

Just don't do this to assign a default object, or you'll get the same object reference in each variable!

Comments

1

If you want to declare multiple const variables you can do that by

const [a, b, c, d] = [[], [], [], []]

assign empty objects or any values at the same time.

Comments

-6

Assign multiple variables to the same value in Javascript?

let a=10
let b=10
let c=10
let d=10
let e=10
console.log(a,b,c,d,e)

1 Comment

Welcome to SO! As stated in the question, this is just the method, the OP doesn't want to use.
-15

Put the varible in an array and Use a for Loop to assign the same value to multiple variables.

  myArray[moveUP, moveDown, moveLeft];

    for(var i = 0; i < myArray.length; i++){

        myArray[i] = true;

    }

2 Comments

This is very wrong.The first statement doesn't make syntactical sense and the for loop is just assigning values to the myArray indices.
Ignoring the syntaxes, they simply wanted cool stuff with different vars, not a bad stuff with a list.