Can I make a PHP function to create text input fields? [duplicate]

Question

So I'm going to be making a couple forms with multiple text input boxes, so I figured making a function to help automate this would be a good idea.

Below is the function I've come up with: however, the results I've gotten seem to be really weird, being a combination of "echo" and a mess of single quotes. Does everything look correct in there? I'm new to PHP, so I'm really sorry if it's an obvious mistake I'm missing.

    function makeTextInputField($name)
    {
echo '<label for = "<?php $name ?>"> <?php ucfirst($name) ?> </label><input type = "text" name = "<?php $name?>"></input>';
    }

sAnS · Accepted Answer · 2013-05-26 08:29:07Z

3

You should not use any more tag inside the php

function makeTextInputField($name)
        {
    echo '<label for = "'.$name.'">'.ucfirst($name).'</label><input type = "text" name = "'.$name.'" />';
        }

edited May 26, 2013 at 8:29

answered May 26, 2013 at 8:17

sAnS

1,1631 gold badge8 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user1823761 Over a year ago

The input tag must be closed with this syntax: <input />. There is no need </input>.

Nasreddine · Accepted Answer · 2013-05-26 08:40:58Z

Working Demo

Because you can insert line breaks in strings in PHP, you can make your function more readable by using variables inside it:

<?php

    function makeTextInputField($name) {
        $text = ucfirst($name);
        echo "
            <label for='{$name}'>{$text}</label>
            <input type='text' name='{$name}' />
        ";
    }

?>

And whenver you want to use it:

<h1>Welcome</h1>
<?php makeTextInputField('email'); ?>

OUTPUT

<h1>Welcome</h1>
<label for='email'>Email</label>
<input type='text' name='email' />

Sobit Akhmedov · Accepted Answer · 2013-05-26 08:20:39Z

1

Your problem is that inside PHP code you're opening new PHP tags, which actually are not required. Try this function and see if it's working for you:

function makeTextInputField($name)
{
    echo sprintf('<label for="%s">%s</label> <input type="text" name="%s"></input>', $name, ucfirst($name), $name);
}

answered May 26, 2013 at 8:20

Sobit Akhmedov

3922 silver badges8 bronze badges

3 Comments

elclanrs Over a year ago

I guess people dont like sprintf. So sad. :(

brasofilo Over a year ago

echo sprintf() is the same as printf() :)

mickmackusa Over a year ago

echo sprintf() is an "antipattern". There is absolutely no reason that anyone should ever write echo sprintf() in any code for any reason -- it should be printf() without echo every time.

elclanrs · Accepted Answer · 2013-05-26 08:20:35Z

0

Try with sprintf.

function textInput($name)
{
  $html = '<label for="%1$s">%2$s</label><input type="text" name="%1$s"/>';
  echo sprintf($html, $name, ucfirst($name));
}

answered May 26, 2013 at 8:20

elclanrs

94.2k21 gold badges137 silver badges171 bronze badges

1 Comment

mickmackusa Over a year ago

echo sprintf() is an "antipattern". There is absolutely no reason that anyone should ever write echo sprintf() in any code for any reason -- it should be printf() without echo every time.

Saurabh Chandra Patel · Accepted Answer · 2013-05-26 08:37:31Z

<?php

class DeInput
{
    protected $_format = '<div>
                 <label for="%s">%s</label>
                 <input  class="formfield" type="text"   name="%s"  value="%s">
                 </div>';
        public function render($content,$getFullyQualifiedName,$getValue,$getLabel)
    {

        $name = htmlentities($getFullyQualifiedName);
        $label = htmlentities($getLabel); 
        $value = htmlentities($getValue);
        $markup = sprintf($this->_format, $name, $label,  $name, $value);
        return $markup;
    }


}

Mihkel Selgal · Accepted Answer · 2013-05-26 08:38:23Z

0

Putting PHP code inside quotation marks is somewhat bad practice so I using (.) point to combine strings can be used.

Here is my example:

function makeTextInputField($name) {
    echo '<label for="'. $name .'">'.ucfirst($name).'</label>';
    echo '<input type="text" name="'.$name .' />';
}

answered May 26, 2013 at 8:38

Mihkel Selgal

5086 silver badges13 bronze badges

Comments

Anatoliy Gusarov · Accepted Answer · 2013-05-26 08:39:11Z

use return intead of echo, and it will be easier to manipulate with result. Also you can split elements generation into different functions for more flexibility:

function createLabel($for,$labelText){
    return '<label for = "'.$for.'"> '.ucfirst($labelText).'</label>';
}

function createTextInput($name,$value,$id){
    return '<input type = "text" name = "'.$name.'" id="'.$id.'">'.$value.'</input>';
}

function myTextInput($name,$value,$labelText){
    $id = 'my_input_'.$name;
    return createLabel($id,$labelText).createTextInput($name,$value,$id);
}

echo myTextInput('email','','Type you email');

DickieBoy · Accepted Answer · 2013-05-26 08:45:09Z

0

function makeTextInputField($name)
{
echo '<label for = "'.$name.'"> '.ucfirst($name).'</label><input type = "text" name = "'.$name.'"></input>';
 }

That should work.

You are already in php. So no need for the <?php tags. Concatenate strings together with a .

edited May 26, 2013 at 8:45

answered May 26, 2013 at 8:19

DickieBoy

4,9661 gold badge31 silver badges49 bronze badges

Collectives™ on Stack Overflow

Can I make a PHP function to create text input fields? [duplicate]

8 Answers 8

1 Comment

Comments

3 Comments

1 Comment

Comments

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

1 Comment

Comments

3 Comments

1 Comment

Comments

Comments

Comments

Comments

Linked

Related