JavaScript: Syntax error? Is it?

Question

I have one very simple Javascript code. The code is to change the source of the image when the page loads. It goes something like this:

window.onload = initAll;
function initAll(){
    document.getElementById("imgSlider").src = "menuBack.jpg";
}

Now, this works perfectly fine. Look at the code below.

window.onload = initAll;
function initAll(){
     var imgSrc = document.getElementById("imgSlider").src
     imgSrc = "menuBack.jpg";

}

Shouldn't this code perform as the code above? I guess, it should. Is there something wrong in the lower code? I use Mozilla Firefox(latest version). Could this be the problem of the browser?

@MM. that is true, which doesn't mean you should rely on it, but I admit that is not the root cause for the problem... — rene
– rene, Commented May 11, 2013 at 9:47

chtenb · Accepted Answer · 2013-05-11 09:42:58Z

3

The second piece of code should definitely do something else.

The first part:

document.getElementById("imgSlider").src = "menuBack.jpg";

means that you store the string "menuBack.jpg" into document.getElementById("imgSlider").src.

However, the second part:

 var imgSrc = document.getElementById("imgSlider").src
 imgSrc = "menuBack.jpg";

means that you first store document.getElementById("imgSlider").src into imgSrc, but then overwrite that by storing "menuBack.jpg" into imgSrc. That is something different.

answered May 11, 2013 at 9:42

chtenb

16.4k15 gold badges84 silver badges120 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mithun Satheesh · Accepted Answer · 2013-05-11 09:39:44Z

3

do like

var imgSrc = document.getElementById("imgSlider");
imgSrc.src = "menuBack.jpg";

You should have the dom element in your variable to apply the value to its attribute. Other ways you just have a string which is not dom element.

answered May 11, 2013 at 9:39

Mithun Satheesh

27.9k14 gold badges80 silver badges103 bronze badges

Comments

score 2 · Accepted Answer · 2013-05-11 09:53:15Z

2

window.onload = initAll;
function initAll(){
     var img = document.getElementById("imgSlider");
     img.src = "menuBack.jpg";
}

edited May 11, 2013 at 9:53

answered May 11, 2013 at 9:41

user1546328

Collectives™ on Stack Overflow

JavaScript: Syntax error? Is it?

3 Answers 3

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Related