trouble with for loop in Java

Question

As i really like Programming and i like to program in my free time so i was trying to create a code in which the output would look like an x. Something like this.

x    x
 x  x
  x
 x  x
x    x

So i wanted the user to input the height of the "x". This is the code i have so far and i really don't know how to move on. I just need a hint or if anyone can tell me where i went wrong.

import java.util.Scanner;    
    public class x{
    public static void main(String[] args){
    Scanner kbd = new Scanner(System.in);
    int height;    
    System.out.print("Enter the height of the X:   " );             
    height = kbd.nextInt();
    for (int i = 1; i <= height; i++){                        
      for (int j = 1; j <= height; j++) {                            
        if(i ==j || j+i == height + 1)                               
            System.out.println("x");                            
        else                            
            System.out.print(" ");
      }
    }
  }
}

You don't always need new line after x in System.out.println("x"); correct this. — Grijesh Chauhan
– Grijesh Chauhan, Commented Apr 26, 2013 at 17:21
oh actually i think Grijesh deserves to be the answerer of this question. — Daniel S.
– Daniel S., Commented Apr 26, 2013 at 17:23
@SlaterTyranus That is correct if you are iterating an array or a list. However, here it is just a counter in a for-loop, and the break condition is using <=, so for this particular use case it does not matter. — matsev
– matsev, Commented Apr 26, 2013 at 17:27

Daniel S. · Accepted Answer · 2013-05-27 11:30:05Z

5

Two changes:

change System.out.println("x"); to System.out.print("x"); (remove ln after print)

after the two lines

    System.out.print(" ");
}

add

System.out.println();

edited May 27, 2013 at 11:30

answered Apr 26, 2013 at 17:24

Daniel S.

6,7004 gold badges41 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Richard Tingle Over a year ago

"add System.out.println(); after the line System.out.print(" ");" surely not straight after, but after the }, or else each blank space will get a new line

Daniel S. Over a year ago

that's right, Richard. thanks for the heads up! i'll edit answer.

elias · Accepted Answer · 2013-04-26 17:29:27Z

0

 for (int i = 0; i < height; i++){                        
    for (int j = 0; j < height; j++) {                            
        if(i == j || j + i == height - 1)                               
            System.out.print("x");                            
        else                            
            System.out.print(" ");
    }
    System.out.println();
 }

answered Apr 26, 2013 at 17:29

elias

15.6k4 gold badges45 silver badges66 bronze badges

Comments

Steven Leimberg · Accepted Answer · 2013-04-26 17:46:35Z

This works for me for both odd and even height's of X:

import java.util.Scanner;  
public class x{
    public static void main(String[] args){
    Scanner kbd = new Scanner(System.in);
    int height;    
    System.out.print("Enter the height of the X:   " );             
    height = kbd.nextInt();
    for (int i = 0; i <= height; i++){                        
      for (int j = 0; j <= height; j++) {                            
        if( (i ==j && i!=0 ) || j+i == height + 1) //needed to check for i or j !=0
            System.out.print("x"); //this shouldn't be println             
        else                            
            System.out.print(" ");
      }
      System.out.println(); //you needed this
    }
  }
}

Collectives™ on Stack Overflow

trouble with for loop in Java

3 Answers 3

2 Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Related