PHP URL encoding with HTTP GET request

Question

I've set up a PHP script to send a text message using the Nexmo API, however there's a problem with how I'm encoding the HTTP GET request. The script pulls some variables from stored data, and then fires. I'm not experienced with PHP and have spent so much time on this already, this is my last resort, is anyone able to see where I've gone wrong in the following code?

The intended format for the request:

https://rest.nexmo.com/sms/json?api_key=XXX&api_secret=XXX&to=XXX&from=XXX&text=XXX

The code:

function sendText () {

    $api_key = $settings['consumer_key'];
    $api_secret = $settings['consumer_secret'];
    $recipient = $settings['recipient'];
    $from = $settings['from'];
    $text = $settings['sms_contents'];

    $url = 'https://rest.nexmo.com/sms/json';
    $data = array_merge($data, array('api_key' => $api_key, 'api_secret' => $api_secret, 'to' => $recipient, 'from' => $from, 'text' => $text));

    $post = '';
    foreach($data as $k => $v) {
        $post .= "&$k=$v";
    }

    $opts = array('http' =>
            array(
                'method'  => 'POST',
                'header'  => 'Content-type: application/x-www-form-urlencoded',
                'content' => $post
            )
        );
    $context = stream_context_create($opts);
    $from_nexmo = file_get_contents($url, false, $context);

}

sendText();

Peter Mortensen · Accepted Answer · 2022-12-02 23:05:12Z

1

I don’t think you are doing any encoding. Here is what I would do:

foreach($data as $k => $v){
    $post .= "&$k=" . urlencode($v);
}

edited Dec 2, 2022 at 23:05

Peter Mortensen

31.4k22 gold badges110 silver badges134 bronze badges

answered Apr 26, 2013 at 4:41

Ibu

43.9k14 gold badges82 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Peter Mortensen · Accepted Answer · 2022-12-02 23:03:19Z

0

Try to use urlencode() for transferred values:

$post = array();

foreach($data as $k => $v){
    $post[] = $k . '=' . urlencode($v);
}

$post = implode('&', $post);

$opts = array('http' =>
        array(
            'method'  => 'POST',
            'header'  => 'Content-type: application/x-www-form-urlencoded',
            'content' => $post
        )
    );

edited Dec 2, 2022 at 23:03

Peter Mortensen

31.4k22 gold badges110 silver badges134 bronze badges

answered Apr 26, 2013 at 4:41

BlitZ

12.2k3 gold badges52 silver badges70 bronze badges

1 Comment

BlitZ Over a year ago

@Jeremy Hewitt , Good luck.

Peter Mortensen · Accepted Answer · 2022-12-02 23:05:40Z

Please try executing the following code snippet:

function sendText () {

    $api_key = $settings['consumer_key'];
    $api_secret = $settings['consumer_secret'];
    $recipient = $settings['recipient'];
    $from = $settings['from'];
    $text = $settings['sms_contents'];

    $url = 'https://rest.nexmo.com/sms/json';
    $data = array_merge($data, array('api_key' => $api_key, 'api_secret' => $api_secret, 'to' => $recipient, 'from' => $from, 'text' => $text));

    $post = http_build_query($data);

    $opts = array('http' =>
            array(
                'method'  => 'POST',
                'header'  => 'Content-type: application/x-www-form-urlencoded',
                'content' => $post
            )
        );

    $context = stream_context_create($opts);
    $from_nexmo = file_get_contents($url, false, $context);
}

sendText();

Collectives™ on Stack Overflow

PHP URL encoding with HTTP GET request

3 Answers 3

Comments

1 Comment

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Related